From f9feef3e16ca7e95cbd0e1a1586ed443f5686b42 Mon Sep 17 00:00:00 2001 From: "tyoshino@chromium.org" Date: Fri, 14 Mar 2014 19:14:42 +0000 Subject: Explain the reason why we don't have thread check in destructor of ByteStreamReader/Writer. They can be deleted before being used and it's safe to do so. Review URL: https://codereview.chromium.org/22925003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257173 0039d316-1c4b-4281-b951-d872f2087c98 --- content/browser/byte_stream.cc | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'content/browser/byte_stream.cc') diff --git a/content/browser/byte_stream.cc b/content/browser/byte_stream.cc index 7b0f9fb..0cd3cd8 100644 --- a/content/browser/byte_stream.cc +++ b/content/browser/byte_stream.cc @@ -194,6 +194,9 @@ ByteStreamWriterImpl::ByteStreamWriterImpl( } ByteStreamWriterImpl::~ByteStreamWriterImpl() { + // No RunsTasksOnCurrentThread() check to allow deleting a created writer + // before we start using it. Once started, should be deleted on the specified + // task runner. my_lifetime_flag_->is_alive = false; } @@ -323,6 +326,9 @@ ByteStreamReaderImpl::ByteStreamReaderImpl( } ByteStreamReaderImpl::~ByteStreamReaderImpl() { + // No RunsTasksOnCurrentThread() check to allow deleting a created writer + // before we start using it. Once started, should be deleted on the specified + // task runner. my_lifetime_flag_->is_alive = false; } -- cgit v1.1