From 680d2d4ac6f87ccd8c151d9d315d4251245fcaf4 Mon Sep 17 00:00:00 2001 From: "jam@chromium.org" Date: Mon, 18 Jul 2011 22:58:21 +0000 Subject: Avoid having SavePackageFilePicker keep a reference to SavePackage, to avoid interfering with its lifetime. BUG=82782 Review URL: http://codereview.chromium.org/7398003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92918 0039d316-1c4b-4281-b951-d872f2087c98 --- content/browser/content_browser_client.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'content/browser/content_browser_client.h') diff --git a/content/browser/content_browser_client.h b/content/browser/content_browser_client.h index c5cedc2..3cd4729 100644 --- a/content/browser/content_browser_client.h +++ b/content/browser/content_browser_client.h @@ -9,6 +9,7 @@ #include #include "base/callback_old.h" +#include "base/memory/weak_ptr.h" #include "content/common/content_client.h" #include "content/common/window_container_type.h" #include "third_party/WebKit/Source/WebKit/chromium/public/WebNotificationPresenter.h" @@ -255,9 +256,9 @@ class ContentBrowserClient { // Clears browser cookies. virtual void ClearCookies(RenderViewHost* rvh) = 0; - // Asks the user for the path to save a page. The embedder calls + // Asks the user for the path to save a page. The embedder calls the tab's // SavePackage::OnPathPicked to give the answer. - virtual void ChooseSavePath(SavePackage* save_package, + virtual void ChooseSavePath(const base::WeakPtr& save_package, const FilePath& suggested_path, bool can_save_as_complete) = 0; -- cgit v1.1