From 66ab87e8ebc518ab54238f9899f813311844997b Mon Sep 17 00:00:00 2001 From: "creis@chromium.org" <creis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Mon, 7 Oct 2013 19:45:52 +0000 Subject: Clean up ResourceHandler API. 1. Move URLRequest member to ResourceHandler base class and add convenience functions for subclasses. 2. Make OnWillRead take a scoped_refptr to avoid leaking the buffer. BUG=295239 TEST=No behavior change. Review URL: https://codereview.chromium.org/25536005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227318 0039d316-1c4b-4281-b951-d872f2087c98 --- content/browser/loader/async_resource_handler.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'content/browser/loader/async_resource_handler.h') diff --git a/content/browser/loader/async_resource_handler.h b/content/browser/loader/async_resource_handler.h index 0992841..4d980d2 100644 --- a/content/browser/loader/async_resource_handler.h +++ b/content/browser/loader/async_resource_handler.h @@ -50,7 +50,7 @@ class AsyncResourceHandler : public ResourceHandler, const GURL& url, bool* defer) OVERRIDE; virtual bool OnWillRead(int request_id, - net::IOBuffer** buf, + scoped_refptr<net::IOBuffer>* buf, int* buf_size, int min_size) OVERRIDE; virtual bool OnReadCompleted(int request_id, @@ -73,7 +73,6 @@ class AsyncResourceHandler : public ResourceHandler, void ResumeIfDeferred(); scoped_refptr<ResourceBuffer> buffer_; - net::URLRequest* request_; ResourceDispatcherHostImpl* rdh_; // Number of messages we've sent to the renderer that we haven't gotten an -- cgit v1.1