From 36b6aec9a5f4953e2177146503096ca7de00cc36 Mon Sep 17 00:00:00 2001 From: dcheng Date: Fri, 25 Dec 2015 22:16:36 -0800 Subject: =?UTF-8?q?Convert=20Pass()=E2=86=92std::move()=20in=20//content/b?= =?UTF-8?q?rowser?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit BUG=557422 Review URL: https://codereview.chromium.org/1545243002 Cr-Commit-Position: refs/heads/master@{#366894} --- .../browser/loader/resource_scheduler_unittest.cc | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) (limited to 'content/browser/loader/resource_scheduler_unittest.cc') diff --git a/content/browser/loader/resource_scheduler_unittest.cc b/content/browser/loader/resource_scheduler_unittest.cc index 509d692..1399b52 100644 --- a/content/browser/loader/resource_scheduler_unittest.cc +++ b/content/browser/loader/resource_scheduler_unittest.cc @@ -4,6 +4,8 @@ #include "content/browser/loader/resource_scheduler.h" +#include + #include "base/memory/scoped_vector.h" #include "base/message_loop/message_loop.h" #include "base/metrics/field_trial.h" @@ -53,8 +55,8 @@ class TestRequest : public ResourceController { scoped_ptr throttle, ResourceScheduler* scheduler) : started_(false), - url_request_(url_request.Pass()), - throttle_(throttle.Pass()), + url_request_(std::move(url_request)), + throttle_(std::move(throttle)), scheduler_(scheduler) { throttle_->set_controller_for_testing(this); } @@ -102,10 +104,10 @@ class CancelingTestRequest : public TestRequest { CancelingTestRequest(scoped_ptr url_request, scoped_ptr throttle, ResourceScheduler* scheduler) - : TestRequest(url_request.Pass(), throttle.Pass(), scheduler) {} + : TestRequest(std::move(url_request), std::move(throttle), scheduler) {} void set_request_to_cancel(scoped_ptr request_to_cancel) { - request_to_cancel_ = request_to_cancel.Pass(); + request_to_cancel_ = std::move(request_to_cancel); } private: @@ -181,7 +183,7 @@ class ResourceSchedulerTest : public testing::Test { int route_id) { scoped_ptr url_request( context_.CreateRequest(GURL(url), priority, NULL)); - return url_request.Pass(); + return url_request; } scoped_ptr NewURLRequest(const char* url, @@ -238,8 +240,8 @@ class ResourceSchedulerTest : public testing::Test { NewURLRequestWithChildAndRoute(url, priority, child_id, route_id)); scoped_ptr throttle(scheduler_->ScheduleRequest( child_id, route_id, is_async, url_request.get())); - TestRequest* request = - new TestRequest(url_request.Pass(), throttle.Pass(), scheduler()); + TestRequest* request = new TestRequest(std::move(url_request), + std::move(throttle), scheduler()); request->Start(); return request; } @@ -403,11 +405,11 @@ TEST_F(ResourceSchedulerTest, CancelOtherRequestsWhileResuming) { scoped_ptr throttle(scheduler()->ScheduleRequest( kChildId, kRouteId, true, url_request.get())); scoped_ptr low2(new CancelingTestRequest( - url_request.Pass(), throttle.Pass(), scheduler())); + std::move(url_request), std::move(throttle), scheduler())); low2->Start(); scoped_ptr low3(NewRequest("http://host/low3", net::LOWEST)); - low2->set_request_to_cancel(low3.Pass()); + low2->set_request_to_cancel(std::move(low3)); scoped_ptr low4(NewRequest("http://host/low4", net::LOWEST)); EXPECT_TRUE(high->started()); -- cgit v1.1