From ef5306ef2dc2460f0a0af8498f80d712ab3ec0b6 Mon Sep 17 00:00:00 2001 From: "creis@chromium.org" Date: Tue, 15 Oct 2013 19:38:18 +0000 Subject: Clean up ResourceHandler API. 1. Move URLRequest member to ResourceHandler base class and add convenience functions for subclasses. 2. Make OnWillRead take a scoped_refptr to avoid leaking the buffer. (Attempt 2, after being reverted for possibly unrelated crashes.) BUG=295239 TEST=No behavior change. TBR=darin Review URL: https://codereview.chromium.org/26420005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228741 0039d316-1c4b-4281-b951-d872f2087c98 --- content/browser/loader/sync_resource_handler.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'content/browser/loader/sync_resource_handler.h') diff --git a/content/browser/loader/sync_resource_handler.h b/content/browser/loader/sync_resource_handler.h index 358d92a..41c51f2 100644 --- a/content/browser/loader/sync_resource_handler.h +++ b/content/browser/loader/sync_resource_handler.h @@ -47,7 +47,7 @@ class SyncResourceHandler : public ResourceHandler { const GURL& url, bool* defer) OVERRIDE; virtual bool OnWillRead(int request_id, - net::IOBuffer** buf, + scoped_refptr* buf, int* buf_size, int min_size) OVERRIDE; virtual bool OnReadCompleted(int request_id, @@ -64,7 +64,6 @@ class SyncResourceHandler : public ResourceHandler { scoped_refptr read_buffer_; SyncLoadResult result_; - net::URLRequest* request_; IPC::Message* result_message_; ResourceDispatcherHostImpl* rdh_; }; -- cgit v1.1