From edce9a33027cc5f73c4866d70e34f690f6720a56 Mon Sep 17 00:00:00 2001 From: brettw Date: Wed, 15 Jul 2015 23:48:05 -0700 Subject: Remove some legacy versions of StartsWith and EndsWith. This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1239493005 Cr-Commit-Position: refs/heads/master@{#338996} --- content/browser/plugin_service_impl.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'content/browser/plugin_service_impl.cc') diff --git a/content/browser/plugin_service_impl.cc b/content/browser/plugin_service_impl.cc index 93140c2..eadffcc 100644 --- a/content/browser/plugin_service_impl.cc +++ b/content/browser/plugin_service_impl.cc @@ -581,7 +581,8 @@ base::string16 PluginServiceImpl::GetPluginDisplayNameByPath( // Many plugins on the Mac have .plugin in the actual name, which looks // terrible, so look for that and strip it off if present. const std::string kPluginExtension = ".plugin"; - if (base::EndsWith(plugin_name, base::ASCIIToUTF16(kPluginExtension), true)) + if (base::EndsWith(plugin_name, base::ASCIIToUTF16(kPluginExtension), + base::CompareCase::SENSITIVE)) plugin_name.erase(plugin_name.length() - kPluginExtension.length()); #endif // OS_MACOSX } -- cgit v1.1