From cfa4e4bc94157b66e59d02c721387323a06b2af3 Mon Sep 17 00:00:00 2001 From: "mattm@chromium.org" Date: Thu, 29 May 2014 21:10:32 +0000 Subject: Revert 273575 "Introduce IPC::Channel::Create*() to ensure it be..." Broke win compile. > Introduce IPC::Channel::Create*() to ensure it being heap-allocated. > > This change introduces IPC::Channel::Create*() API to turn > IPC::Channel into a heap allocated object. This will allow us to > make Channel a polymorphic class. > > This change also tries to hide Channel::Mode from public API > so that we can simplify channel creation code paths cleaner in > following changes. ChannelProxy has to follow same pattern to > finish this cleanup. Such changes will follow. > > TEST=none > BUG=377980 > R=darin@chromium.org,cpu@chromium.org > > Review URL: https://codereview.chromium.org/307653003 TBR=morrita@chromium.org Review URL: https://codereview.chromium.org/304153005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273596 0039d316-1c4b-4281-b951-d872f2087c98 --- content/browser/plugin_service_impl_browsertest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'content/browser/plugin_service_impl_browsertest.cc') diff --git a/content/browser/plugin_service_impl_browsertest.cc b/content/browser/plugin_service_impl_browsertest.cc index 7a3271e..44f4754 100644 --- a/content/browser/plugin_service_impl_browsertest.cc +++ b/content/browser/plugin_service_impl_browsertest.cc @@ -60,7 +60,7 @@ class MockPluginProcessHostClient : public PluginProcessHost::Client, ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO)); ASSERT_TRUE(set_plugin_info_called_); ASSERT_TRUE(!channel_); - channel_ = IPC::Channel::CreateClient(handle, this).release(); + channel_ = new IPC::Channel(handle, IPC::Channel::MODE_CLIENT, this); ASSERT_TRUE(channel_->Connect()); } -- cgit v1.1