From baa42d336b9a858a1180be0db455a6874761e418 Mon Sep 17 00:00:00 2001 From: huangs Date: Tue, 22 Sep 2015 09:59:54 -0700 Subject: Revert of Architecture for cross-process memory notification suppressing (patchset #11 id:240001 of https://codereview.chromium.org/1332583002/ ) Reason for revert: This seems to cause failure in Cast Linux: content_browsertests: MemoryPressureControllerBrowserTest.SetPressureNotificationsSuppressedInAllProcesses Original issue's description: > Architecture for cross-process memory notification suppressing > > This patch adds IPC architecture for suppressing memory pressure > notifications in all processes: > > BROWSER PROCESS CHILD PROCESSES > > MemoryPressureListener:: MemoryPressureListener:: > SetNotificationsSuppressed SetNotificationsSuppressed > (existing static method*) (existing static method*) > ^ ^ > | | > +--------------------------+ | > | MemoryPressureController | | > +..> | (singleton) | | > : +--------------------------+ | > : | | > : V | > : +--------------------------+ +--------------------------+ > : | MemoryMessageFilter | <===> | ChildMemoryMessageFilter | > : | (per child process) | IPC | (singleton) | > : +--------------------------+ +--------------------------+ > : > : > +.. Memory.setPressureNotificationsSuppressed > (proposed DevTools API**) > > *) The required functionality for individual processes was added in: > https://codereview.chromium.org/1312163003. > **) The new DevTools API will be added in the following 3-sided patch: > https://codereview.chromium.org/1336363002, > https://codereview.chromium.org/1311343007, and > https://codereview.chromium.org/1342833004. > > This patch adds new message filters on both sides (MemoryMessageFilter > in the browser process and ChildMemoryMessageFilter in the child > process) because we anticipate more functionality to be added to > MemoryPressureController in the near future (methods for simulating > memory pressure signals and, more importantly, propagating memory > pressure signals to all processes on desktop Chrome). Encapsulating the > relevant IPC communication in dedicated message filters is arguably > better than keeping augmenting (and having duplicate code in) > BrowserChildProcessHostImpl, RenderProcessHostImpl, and > ChildThreadImpl. > > This patch represents the second step towards implementing a DevTools > API for suppressing and simulating memory pressure signals in Chrome. > The main use case for this feature is to enforce consistent conditions > across memory measurements. See https://goo.gl/cZFdH3 for more details. > > BUG=516776 > > Committed: https://crrev.com/0b119f3392d6c6169bbb792347a04f34ce649156 > Cr-Commit-Position: refs/heads/master@{#350169} TBR=skyostil@chromium.org,primiano@chromium.org,nasko@chromium.org,chrisha@chromium.org,petrcermak@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516776 Review URL: https://codereview.chromium.org/1359873002 Cr-Commit-Position: refs/heads/master@{#350175} --- content/content_common.gypi | 1 - 1 file changed, 1 deletion(-) (limited to 'content/content_common.gypi') diff --git a/content/content_common.gypi b/content/content_common.gypi index 1593e51..905f3bd 100644 --- a/content/content_common.gypi +++ b/content/content_common.gypi @@ -446,7 +446,6 @@ 'common/media/video_capture_messages.h', 'common/media/webrtc_identity_messages.h', 'common/memory_benchmark_messages.h', - 'common/memory_messages.h', 'common/message_port_messages.h', 'common/message_router.cc', 'common/message_router.h', -- cgit v1.1