From 0fb7f983997760be537218e91f61a2a14fbdf648 Mon Sep 17 00:00:00 2001 From: "kbr@chromium.org" Date: Tue, 19 Mar 2013 03:06:26 +0000 Subject: Removed support for Core Animation plugins when accelerated compositing is disabled. CA plugins have been rendered through Chrome's compositor for several releases now and it has not been found necessary to revert back to the older behavior. If the compositor is disabled, then support for the Core Animation and Invalidating Core Animation drawing models is no longer advertised. Tested with the Unity and NPAPI Flash plugins. As expected, Unity no longer renders with the compositor disabled; NPAPI Flash falls back to the Core Graphics drawing model. (Pepper Flash is not affected; it happens to require the compositor before and after this change.) BUG=105344 Review URL: https://chromiumcodereview.appspot.com/12641008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188928 0039d316-1c4b-4281-b951-d872f2087c98 --- content/plugin/webplugin_proxy.h | 35 +---------------------------------- 1 file changed, 1 insertion(+), 34 deletions(-) (limited to 'content/plugin/webplugin_proxy.h') diff --git a/content/plugin/webplugin_proxy.h b/content/plugin/webplugin_proxy.h index aa2aecb..307e373 100644 --- a/content/plugin/webplugin_proxy.h +++ b/content/plugin/webplugin_proxy.h @@ -135,40 +135,7 @@ class WebPluginProxy : public webkit::npapi::WebPlugin { GetAcceleratedSurface(gfx::GpuPreference gpu_preference) OVERRIDE; //---------------------------------------------------------------------- - // Legacy Core Animation plugin implementation rendering directly to screen. - - virtual void BindFakePluginWindowHandle(bool opaque) OVERRIDE; - - // Tell the browser (via the renderer) to invalidate because the - // accelerated buffers have changed. - virtual void AcceleratedFrameBuffersDidSwap( - gfx::PluginWindowHandle window, uint64 surface_id); - - // Tell the renderer and browser to associate the given plugin handle with - // |accelerated_surface_identifier|. The geometry is used to resize any - // native "window" (which on the Mac is a just a view). - // This method is used when IOSurface support is available. - virtual void SetAcceleratedSurface(gfx::PluginWindowHandle window, - const gfx::Size& size, - uint64 accelerated_surface_identifier); - - // Tell the renderer and browser to associate the given plugin handle with - // |dib_handle|. The geometry is used to resize any native "window" (which - // on the Mac is just a view). - // This method is used when IOSurface support is not available. - virtual void SetAcceleratedDIB( - gfx::PluginWindowHandle window, - const gfx::Size& size, - const TransportDIB::Handle& dib_handle); - - // Create/destroy TranportDIBs via messages to the browser process. - // These are only used when IOSurface support is not available. - virtual void AllocSurfaceDIB(const size_t size, - TransportDIB::Handle* dib_handle); - virtual void FreeSurfaceDIB(TransportDIB::Id dib_id); - - //---------------------------------------------------------------------- - // New accelerated plugin implementation which renders via the compositor. + // Accelerated plugin implementation which renders via the compositor. // Tells the renderer, and from there the GPU process, that the plugin // is using accelerated rather than software rendering. -- cgit v1.1