From 75c4422d8fdabd231f40a6c9235f4512f0170268 Mon Sep 17 00:00:00 2001 From: jam Date: Tue, 22 Mar 2016 22:34:24 -0700 Subject: Remove logic for lazy initialization of WebKit. See "Extensions impact on startup?" thread on (internal) chrome-fast mailing list from 8/14/2015 for background, which showed that effectively undoing this logic showed a 3% reduction on first_non_empty_paint_time. This lazy initialization used to be a performance win when it was added years ago, but has since become a performance drag. Since it's effectively not used now (since ChromeContentRendererClient::RenderThreadStarted always initializes WebKit through its call to RenderThread::RegisterExtension), just remove this unused logic. Review URL: https://codereview.chromium.org/1821413003 Cr-Commit-Position: refs/heads/master@{#382795} --- content/public/renderer/render_process_observer.h | 3 --- content/public/renderer/render_thread.h | 4 ---- 2 files changed, 7 deletions(-) (limited to 'content/public/renderer') diff --git a/content/public/renderer/render_process_observer.h b/content/public/renderer/render_process_observer.h index f53ba65..30f855d 100644 --- a/content/public/renderer/render_process_observer.h +++ b/content/public/renderer/render_process_observer.h @@ -27,9 +27,6 @@ class CONTENT_EXPORT RenderProcessObserver { // Notification that the render process is shutting down. virtual void OnRenderProcessShutdown() {} - // Called right after the WebKit API is initialized. - virtual void WebKitInitialized() {} - // Called when the renderer cache of the plugin list has changed. virtual void PluginListChanged() {} diff --git a/content/public/renderer/render_thread.h b/content/public/renderer/render_thread.h index db554c1..7f88da9 100644 --- a/content/public/renderer/render_thread.h +++ b/content/public/renderer/render_thread.h @@ -75,10 +75,6 @@ class CONTENT_EXPORT RenderThread : virtual public ChildThread { virtual void SetResourceDispatcherDelegate( ResourceDispatcherDelegate* delegate) = 0; - // We initialize WebKit as late as possible. Call this to force - // initialization. - virtual void EnsureWebKitInitialized() = 0; - // Asks the host to create a block of shared memory for the renderer. // The shared memory allocated by the host is returned back. virtual scoped_ptr HostAllocateSharedMemoryBuffer( -- cgit v1.1