From f510be61306f5e4986eceb1f8686bfcc934cd400 Mon Sep 17 00:00:00 2001 From: brettw Date: Thu, 24 Mar 2016 17:41:11 -0700 Subject: Content "gn check" work. Make content/gpu and content/plugin pass GN check. Makes most of content/shell and content/test pass check. These are not all enabled yet pending a few remaining issues that are more difficult to solve. The private content targets now allow content/test to include headers from them for non-component builds. Checking is disabled for content/test in component builds as described in the comment at the top of //content/BUILD.gn Renames the ui/events/ipc according to GN style BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jschuh (IPC build tweak) Review URL: https://codereview.chromium.org/1828483002 Cr-Commit-Position: refs/heads/master@{#383208} --- content/public/browser/BUILD.gn | 2 +- content/public/gpu/BUILD.gn | 2 ++ content/public/plugin/BUILD.gn | 8 +++++++- 3 files changed, 10 insertions(+), 2 deletions(-) (limited to 'content/public') diff --git a/content/public/browser/BUILD.gn b/content/public/browser/BUILD.gn index 643cb8f..4d6d84c 100644 --- a/content/public/browser/BUILD.gn +++ b/content/public/browser/BUILD.gn @@ -40,7 +40,7 @@ source_set("browser_sources") { ] deps = [ "//cc", - "//content/browser", + "//content/browser", # Must not be public_deps! "//content/public/common:common_sources", "//gpu", "//media", diff --git a/content/public/gpu/BUILD.gn b/content/public/gpu/BUILD.gn index 3bca008..708d8b6 100644 --- a/content/public/gpu/BUILD.gn +++ b/content/public/gpu/BUILD.gn @@ -28,4 +28,6 @@ source_set("gpu_sources") { "//content/gpu:gpu_sources", "//content/public/common:common_sources", ] + + allow_circular_includes_from = [ "//content/gpu:gpu_sources" ] } diff --git a/content/public/plugin/BUILD.gn b/content/public/plugin/BUILD.gn index e4c4d36..1a0bfd9 100644 --- a/content/public/plugin/BUILD.gn +++ b/content/public/plugin/BUILD.gn @@ -24,7 +24,13 @@ source_set("plugin_sources") { deps = [ "//base", - "//content/plugin", + "//content/plugin", # Must not be a public dep. "//content/public/common:common_sources", ] + + allow_circular_includes_from = [ + # This target is a pair with content/plugin. They always go together and + # include headers from each other. + "//content/plugin", + ] } -- cgit v1.1