From ece20f57928501899c46a8a73119f88b562c2fba Mon Sep 17 00:00:00 2001 From: "steveblock@chromium.org" Date: Mon, 14 May 2012 20:22:25 +0000 Subject: Fix JavaBridgeDispatcher to ref-count JavaBridgeChannel JavaBridgeChannel inherits from NPChannelBase, which is ref-counted, so we should use scoped_refptr, not scoped_ptr. Review URL: https://chromiumcodereview.appspot.com/10356149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136965 0039d316-1c4b-4281-b951-d872f2087c98 --- content/renderer/java/java_bridge_channel.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'content/renderer/java/java_bridge_channel.h') diff --git a/content/renderer/java/java_bridge_channel.h b/content/renderer/java/java_bridge_channel.h index 7bf500c..1700703 100644 --- a/content/renderer/java/java_bridge_channel.h +++ b/content/renderer/java/java_bridge_channel.h @@ -14,7 +14,6 @@ class JavaBridgeChannel : public NPChannelBase { static JavaBridgeChannel* GetJavaBridgeChannel( const IPC::ChannelHandle& channel_handle, base::MessageLoopProxy* ipc_message_loop); - virtual ~JavaBridgeChannel() {} // NPChannelBase implementation: virtual int GenerateRouteID() OVERRIDE; @@ -23,7 +22,9 @@ class JavaBridgeChannel : public NPChannelBase { virtual bool OnControlMessageReceived(const IPC::Message& msg) OVERRIDE; private: - JavaBridgeChannel() {} + JavaBridgeChannel(); + // This class is ref-counted. + virtual ~JavaBridgeChannel(); static NPChannelBase* ClassFactory() { return new JavaBridgeChannel(); } -- cgit v1.1