From 5a49bc9eb668725b1c52ce8458eb431b383d8ff7 Mon Sep 17 00:00:00 2001 From: eroman Date: Tue, 11 Nov 2014 11:57:54 -0800 Subject: Cleanup: Don't check for negative values from EVP_DigestVerifyFinal. (No longer a possibility in BoringSSL). Review URL: https://codereview.chromium.org/707973007 Cr-Commit-Position: refs/heads/master@{#303700} --- crypto/signature_verifier_openssl.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'crypto/signature_verifier_openssl.cc') diff --git a/crypto/signature_verifier_openssl.cc b/crypto/signature_verifier_openssl.cc index 53637eb..84aa2ea 100644 --- a/crypto/signature_verifier_openssl.cc +++ b/crypto/signature_verifier_openssl.cc @@ -122,8 +122,7 @@ bool SignatureVerifier::VerifyFinal() { int rv = EVP_DigestVerifyFinal(verify_context_->ctx.get(), vector_as_array(&signature_), signature_.size()); - // rv is -1 if a DER-encoded ECDSA signature cannot be decoded correctly. - DCHECK_GE(rv, -1); + DCHECK_EQ(!!rv, rv); Reset(); return rv == 1; } -- cgit v1.1