From b837df322e4c9669a310c832b447ae12117674ff Mon Sep 17 00:00:00 2001 From: "agl@chromium.org" Date: Tue, 5 Aug 2014 22:58:46 +0000 Subject: Disable Poly1305 NEON code again. The Poly1305 NEON code became live again with the BoringSSL switch. This change disables it again in Chromium because of some broken phones. We should really read /proc/cpuinfo and selectively disable, but this change is simple and keeps the status-quo for now. BUG=341598 Review URL: https://codereview.chromium.org/443523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287630 0039d316-1c4b-4281-b951-d872f2087c98 --- crypto/openssl_util.cc | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'crypto') diff --git a/crypto/openssl_util.cc b/crypto/openssl_util.cc index 94bf246..6f348ff 100644 --- a/crypto/openssl_util.cc +++ b/crypto/openssl_util.cc @@ -62,6 +62,10 @@ class OpenSSLInitSingleton { (android_getCpuFeatures() & ANDROID_CPU_ARM_FEATURE_NEON) != 0; if (has_neon) CRYPTO_set_NEON_capable(1); + // In all cases, currently, mark the NEON unit as broken because some + // phones can't execute the Poly1305 code correctly. See + // https://code.google.com/p/chromium/issues/detail?id=341598 + CRYPTO_set_NEON_functional(0); #endif } -- cgit v1.1