From b24773a4a86203823ae487f8281baa82ac907c47 Mon Sep 17 00:00:00 2001 From: "mostynb@opera.com" Date: Wed, 30 Jul 2014 18:44:31 +0000 Subject: dbus: don't add attributes in extern template class specialization This previous CL added attributes to some template specializations: https://codereview.chromium.org/408143012 This breaks gcc 4.8, which gives the following warning: ../../dbus/property.h:412:62: error: type attributes ignored after type is already defined [-Werror=attributes] Since the template class already has the attribute, I suspect that the additional attribute specifications are redundant. ie I think we can remove them. Review URL: https://codereview.chromium.org/423233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286567 0039d316-1c4b-4281-b951-d872f2087c98 --- dbus/property.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) (limited to 'dbus/property.h') diff --git a/dbus/property.h b/dbus/property.h index d30e076..a20e0ad 100644 --- a/dbus/property.h +++ b/dbus/property.h @@ -409,81 +409,81 @@ class CHROME_DBUS_EXPORT Property : public PropertyBase { template <> Property::Property(); template <> bool Property::PopValueFromReader(MessageReader* reader); template <> void Property::AppendSetValueToWriter(MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property; +extern template class Property; template <> Property::Property(); template <> bool Property::PopValueFromReader(MessageReader* reader); template <> void Property::AppendSetValueToWriter(MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property; +extern template class Property; template <> Property::Property(); template <> bool Property::PopValueFromReader(MessageReader* reader); template <> void Property::AppendSetValueToWriter(MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property; +extern template class Property; template <> Property::Property(); template <> bool Property::PopValueFromReader(MessageReader* reader); template <> void Property::AppendSetValueToWriter( MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property; +extern template class Property; template <> Property::Property(); template <> bool Property::PopValueFromReader(MessageReader* reader); template <> void Property::AppendSetValueToWriter(MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property; +extern template class Property; template <> Property::Property(); template <> bool Property::PopValueFromReader(MessageReader* reader); template <> void Property::AppendSetValueToWriter( MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property; +extern template class Property; template <> Property::Property(); template <> bool Property::PopValueFromReader(MessageReader* reader); template <> void Property::AppendSetValueToWriter(MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property; +extern template class Property; template <> Property::Property(); template <> bool Property::PopValueFromReader(MessageReader* reader); template <> void Property::AppendSetValueToWriter( MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property; +extern template class Property; template <> Property::Property(); template <> bool Property::PopValueFromReader(MessageReader* reader); template <> void Property::AppendSetValueToWriter( MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property; +extern template class Property; template <> bool Property::PopValueFromReader( MessageReader* reader); template <> void Property::AppendSetValueToWriter( MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property; +extern template class Property; template <> bool Property::PopValueFromReader( MessageReader* reader); template <> void Property::AppendSetValueToWriter( MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property; +extern template class Property; template <> bool Property >::PopValueFromReader( MessageReader* reader); template <> void Property >::AppendSetValueToWriter( MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property >; +extern template class Property >; template <> bool Property >::PopValueFromReader( MessageReader* reader); template <> void Property >::AppendSetValueToWriter( MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property >; +extern template class Property >; template <> bool Property >::PopValueFromReader( MessageReader* reader); template <> void Property >::AppendSetValueToWriter( MessageWriter* writer); -extern template class CHROME_DBUS_EXPORT Property >; +extern template class Property >; } // namespace dbus -- cgit v1.1