From dce1abec3dfcb2ee54545d2438368168308b3a92 Mon Sep 17 00:00:00 2001 From: derat Date: Thu, 16 Jul 2015 08:06:44 -0700 Subject: dbus: Add missing destructors to Property and PropertyBase. BUG=none Review URL: https://codereview.chromium.org/1237343003 Cr-Commit-Position: refs/heads/master@{#339031} --- dbus/property.cc | 4 ++++ dbus/property.h | 6 ++++-- 2 files changed, 8 insertions(+), 2 deletions(-) (limited to 'dbus') diff --git a/dbus/property.cc b/dbus/property.cc index 66b86c0..dde0611 100644 --- a/dbus/property.cc +++ b/dbus/property.cc @@ -18,6 +18,10 @@ namespace dbus { // PropertyBase implementation. // +PropertyBase::PropertyBase() : property_set_(nullptr), is_valid_(false) {} + +PropertyBase::~PropertyBase() {} + void PropertyBase::Init(PropertySet* property_set, const std::string& name) { DCHECK(!property_set_); property_set_ = property_set; diff --git a/dbus/property.h b/dbus/property.h index 321f4dbd..5f36d69 100644 --- a/dbus/property.h +++ b/dbus/property.h @@ -132,9 +132,10 @@ class PropertySet; // the Property<> template that are not type-specific, such as the // associated PropertySet, property name, and the type-unsafe parts // used by PropertySet. -class PropertyBase { +class CHROME_DBUS_EXPORT PropertyBase { public: - PropertyBase() : property_set_(nullptr), is_valid_(false) {} + PropertyBase(); + virtual ~PropertyBase(); // Initializes the |property_set| and property |name| so that method // calls may be made from this class. This method is called by @@ -367,6 +368,7 @@ template class CHROME_DBUS_EXPORT Property : public PropertyBase { public: Property() {} + ~Property() override {} // Retrieves the cached value. const T& value() const { return value_; } -- cgit v1.1