From f8330b75d7424cfdf0018dc51a855dc8828862e2 Mon Sep 17 00:00:00 2001 From: reillyg Date: Mon, 12 Jan 2015 18:48:20 -0800 Subject: Mark UsbServiceImpl::UIThreadHelper as final. Silence -Wdelete-non-virtual-dtor warnings on this class by marking it final and inheriting from DeviceMonitorWin::Observe privately. BUG= Review URL: https://codereview.chromium.org/850563002 Cr-Commit-Position: refs/heads/master@{#311188} --- device/usb/usb_service_impl.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'device') diff --git a/device/usb/usb_service_impl.cc b/device/usb/usb_service_impl.cc index 5b4d503..89fbd66a 100644 --- a/device/usb/usb_service_impl.cc +++ b/device/usb/usb_service_impl.cc @@ -106,7 +106,8 @@ class UsbServiceImpl : public UsbService, // device change notification window messages. It registers for notifications // regarding devices implementating the "UsbDevice" interface, which represents // most of the devices the UsbService will enumerate. -class UsbServiceImpl::UIThreadHelper : DeviceMonitorWin::Observer { +class UsbServiceImpl::UIThreadHelper final + : private DeviceMonitorWin::Observer { public: UIThreadHelper(base::WeakPtr usb_service) : task_runner_(base::ThreadTaskRunnerHandle::Get()), -- cgit v1.1