From 46a19f626f5794f298cd1e4d8bdcbfcb07fd0b4e Mon Sep 17 00:00:00 2001 From: "jamescook@chromium.org" Date: Thu, 17 Jul 2014 17:21:45 +0000 Subject: Revert 283678 "Refactor code that defers extension background pa..." This broke Chrome OS valgrind bots, for example: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/27033 > Refactor code that defers extension background page loading > > src/extensions depends on chrome::NOTIFICATION_PROFILE_CREATED to support deferred loading of extension background pages when the profile isn't ready yet. This is a layering violation. > > * Remove Chrome concepts like "browser window ready" and "profile created" from ProcessManager. Introduce ProcessManagerDelegate with a general concept of deferring background page loading. > * Consolidate all the tricky Chrome-specific background page loading rules into ChromeProcessManagerDelegate. This keeps all the rules in one place. Annotate each block of special case code with the bug that inspired it. > * Extend unit test coverage for ProcessManager. > > This will make it easier to eliminate chrome::NOTIFICATION_PROFILE_DESTROYED in ProcessManager in a later CL. > > BUG=392658 > TEST=unit_tests ProcessManagerTest, browser_tests ProcessManagerBrowserTest, manual > > Review URL: https://codereview.chromium.org/381283002 TBR=jamescook@chromium.org Review URL: https://codereview.chromium.org/399153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283801 0039d316-1c4b-4281-b951-d872f2087c98 --- extensions/DEPS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'extensions/DEPS') diff --git a/extensions/DEPS b/extensions/DEPS index 4077a55..0505b02 100644 --- a/extensions/DEPS +++ b/extensions/DEPS @@ -1,5 +1,4 @@ include_rules = [ - # Do not add Chrome dependencies. Much work went into removing them. "+components/url_matcher", "+content/public/common", "+content/public/test", @@ -14,7 +13,7 @@ include_rules = [ # NOTE: Please do not add includes without talking to the app shell team; # see OWNERS for this directory. # - # TODO(jamescook): Remove this. http://crbug.com/392622 + # TODO(jamescook): Remove these. http://crbug.com/162530 "!chrome/browser/chrome_notification_types.h", ] -- cgit v1.1