From e2284fd9e2d42285a925d60aea5b8d0b769b2381 Mon Sep 17 00:00:00 2001 From: rockot Date: Tue, 4 Nov 2014 11:09:25 -0800 Subject: Refine //extensions DEPS on //ui This patch makes more explicit the set of dependencies allowed from //extensions onto //ui. //extensions was allowing dependencies on all of //ui by default. This is unfortunate for people who want to introduce new code into //extensions only to be shot down because they depend on pieces of ui that aren't allowed. BUG=None Review URL: https://codereview.chromium.org/702513002 Cr-Commit-Position: refs/heads/master@{#302637} --- extensions/DEPS | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'extensions/DEPS') diff --git a/extensions/DEPS b/extensions/DEPS index d2bbec8..21a0ba6 100644 --- a/extensions/DEPS +++ b/extensions/DEPS @@ -13,7 +13,16 @@ include_rules = [ "+grit/extensions_resources.h", "+mojo/public", "+testing", - "+ui", + + # Minimal UI dependencies. There are two good rules for UI dependencies here: + # + # 1) UI components should only be added as they are needed, and + # 2) if //content doesn't allow it, //extensions probably won't allow it. + # (see for example ui/views) + "-ui", + "+ui/base", + "+ui/gfx", + "+ui/events", # NOTE: Please do not add includes without talking to the app shell team; # see OWNERS for this directory. -- cgit v1.1