From f79df3346ce523b2c44c7d99e0b819788c432203 Mon Sep 17 00:00:00 2001 From: jamescook Date: Tue, 16 Sep 2014 21:05:10 -0700 Subject: Reland: Refactor ExtensionManifestTest to allow usage in src/extensions Original CL broke the Win official bots because they report their default version channel as "canary" instead of "trunk". https://codereview.chromium.org/572813002 Original description: This refactor will allow some manifest tests running in Chrome's unit_tests suite to move to the extensions_unittests suite. * Rename ExtensionManifestTest to extensions::ManifestTest and move it into src/extensions. * Introduce ChromeManifestTest to load manifests from Chrome's test data dir. * Eliminate some unnecessary use of chrome::VersionInfo::Channel. * Move SharedModuleManifestTest to extensions_unittests as an example. FileHandlerManifestTest and ExternallyConnectableManifestTest will be next, but require more refactoring (e.g. of permissions). BUG=397165 TEST=unit_tests, extensions_unittests TBR=rockot@chromium.org Review URL: https://codereview.chromium.org/574173002 Cr-Commit-Position: refs/heads/master@{#295225} --- extensions/DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'extensions/DEPS') diff --git a/extensions/DEPS b/extensions/DEPS index 836d930..7cfd017 100644 --- a/extensions/DEPS +++ b/extensions/DEPS @@ -39,7 +39,7 @@ specific_include_rules = { "+chrome/browser/ui/browser.h", "+chrome/common/chrome_paths.h", "+chrome/common/extensions/features/feature_channel.h", - "+chrome/common/extensions/manifest_tests/extension_manifest_test.h", + "+chrome/common/extensions/manifest_tests/chrome_manifest_test.h", "+chrome/test/base/testing_profile.h", "+chrome/test/base/ui_test_utils.h", ], -- cgit v1.1