From 16b16fba24fa3cac9e5c852cb707a5317c34ddad Mon Sep 17 00:00:00 2001 From: lazyboy Date: Wed, 16 Mar 2016 13:09:49 -0700 Subject: Skip logging spurious errors for ServiceWorker URLRequests that were spawned through ServiceWorkerWriteToCacheJob. This CL does not fix the underlying issue, it is just suppressing a not so useful error log. BUG=568788 Test=Load an extension page with ServiceWorker, observe no "Allowing load of ..." error messages anymore. Review URL: https://codereview.chromium.org/1790993002 Cr-Commit-Position: refs/heads/master@{#381517} --- extensions/browser/extension_protocols.cc | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) (limited to 'extensions/browser') diff --git a/extensions/browser/extension_protocols.cc b/extensions/browser/extension_protocols.cc index 1fcabe1..2dbbf31 100644 --- a/extensions/browser/extension_protocols.cc +++ b/extensions/browser/extension_protocols.cc @@ -329,9 +329,17 @@ bool AllowExtensionResourceLoad(net::URLRequest* request, // We have seen crashes where info is NULL: crbug.com/52374. if (!info) { - LOG(ERROR) << "Allowing load of " << request->url().spec() - << "from unknown origin. Could not find user data for " - << "request."; + // SeviceWorker net requests created through ServiceWorkerWriteToCacheJob + // do not have ResourceRequestInfo associated with them. So skip logging + // spurious errors below. + // TODO(falken): Either consider attaching ResourceRequestInfo to these or + // finish refactoring ServiceWorkerWriteToCacheJob so that it doesn't spawn + // a new URLRequest. + if (!ResourceRequestInfo::OriginatedFromServiceWorker(request)) { + LOG(ERROR) << "Allowing load of " << request->url().spec() + << "from unknown origin. Could not find user data for " + << "request."; + } return true; } -- cgit v1.1