From cdcc4b87e40c1b783541444d9484f33e81a177ba Mon Sep 17 00:00:00 2001 From: rob Date: Sun, 6 Dec 2015 04:39:45 -0800 Subject: Track all extension frames in ProcessManager, inspect extensionoptions ProcessManager::GetRenderFrameHostsForExtension did not return all RFHs for a given extension, because of two errors: 1. An extension can have multiple SiteInstances, so SiteInstances should not be compared by pointer. 2. ExtensionWebContentsObserver failed to register RFHs after a process swap. I discovered this when I noticed that tests started to fail unexpectedly after applying https://codereview.chromium.org/1413543005. That patch changes the extension messaging API, to route messages to RFHs instead of processes. This requires extension frames to be tracked correctly... Extension tabs, frames, etc. are now visible at "Inspect views" in the extensions view (when developer mode is enabled), thanks to the fact that all extension frames are now being tracked (excluding extension frames that are hosted in a view without classification, e.g. developer tools and most of the GuestViews). BUG=432875,550022 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation TEST=ExtensionApiTest.MessagingNoBackground does not fail any more with https://codereview.chromium.org/1413543005 after applying this patch. DeveloperPrivateApiTest.InspectEmbeddedOptionsPage passes. ProcessManagerBrowserTest.NoBackgroundPage passes. ProcessManagerBrowserTest.FrameClassification passes with and without OOPIF. Review URL: https://codereview.chromium.org/1413853005 Cr-Commit-Position: refs/heads/master@{#363368} --- extensions/common/view_type.h | 1 + 1 file changed, 1 insertion(+) (limited to 'extensions/common') diff --git a/extensions/common/view_type.h b/extensions/common/view_type.h index 82c906b..bbe498d 100644 --- a/extensions/common/view_type.h +++ b/extensions/common/view_type.h @@ -18,6 +18,7 @@ enum ViewType { VIEW_TYPE_BACKGROUND_CONTENTS, VIEW_TYPE_EXTENSION_BACKGROUND_PAGE, VIEW_TYPE_EXTENSION_DIALOG, + VIEW_TYPE_EXTENSION_GUEST, VIEW_TYPE_EXTENSION_POPUP, VIEW_TYPE_LAUNCHER_PAGE, VIEW_TYPE_PANEL, -- cgit v1.1