From fbcb5dee51bebbd01fc7ace6ebe6d9713a0624ca Mon Sep 17 00:00:00 2001 From: cernekee Date: Tue, 9 Feb 2016 14:39:53 -0800 Subject: Fix error in vpnProvider API docs The argument to the createConfig() callback is an undefined variable on error. It is not an empty string. BUG=580760 TEST=chrome.vpnProvider.createConfig("", function(x) { console.debug(typeof(x)); }) TEST=chrome.vpnProvider.createConfig("duplicate_name", function(x) { console.debug(typeof(x)); }) Review URL: https://codereview.chromium.org/1628763002 Cr-Commit-Position: refs/heads/master@{#374504} --- extensions/common/api/vpn_provider.idl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'extensions/common') diff --git a/extensions/common/api/vpn_provider.idl b/extensions/common/api/vpn_provider.idl index ef0e947..a826522 100644 --- a/extensions/common/api/vpn_provider.idl +++ b/extensions/common/api/vpn_provider.idl @@ -83,7 +83,8 @@ namespace vpnProvider { // The callback is used by createConfig to signal completion. // The callback is called with chrome.runtime.lastError set to // an error code if there is an error. - // |id|: A unique ID for the created configuration, empty string on failure. + // |id|: A unique ID for the created configuration, or undefined + // on failure. [inline_doc] callback CreateConfigCompleteCallback = void (DOMString id); interface Functions { -- cgit v1.1