From ffaec53850a27fc0888998c98c7bb092ccbd8552 Mon Sep 17 00:00:00 2001 From: jam Date: Wed, 10 Feb 2016 15:45:40 -0800 Subject: Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. Also add a few checked_cast for places where we converted from size_t and we're sure that it's safe. BUG=581409 Review URL: https://codereview.chromium.org/1684793003 Cr-Commit-Position: refs/heads/master@{#374788} --- extensions/common/stack_frame.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'extensions/common') diff --git a/extensions/common/stack_frame.h b/extensions/common/stack_frame.h index b174ffc..a55b8d8 100644 --- a/extensions/common/stack_frame.h +++ b/extensions/common/stack_frame.h @@ -29,6 +29,9 @@ struct StackFrame { bool operator==(const StackFrame& rhs) const; + // Note: we use uint32_t instead of size_t because this struct is sent over + // IPC which could span 32 & 64 bit processes. This is fine since line numbers + // and column numbers shouldn't exceed UINT32_MAX even on 64 bit builds. uint32_t line_number; uint32_t column_number; base::string16 source; -- cgit v1.1