From 1fbc9540c7a729001f34e2c0d8418f16186ef679 Mon Sep 17 00:00:00 2001 From: dmazzoni Date: Mon, 22 Jun 2015 11:37:48 -0700 Subject: Revert of Revert of Revert of [MacViews] Implement AppWindowNativeWidgetMac::Maximize. (patchset #1 id:1 of https://codereview.chromium.org/1198403003/) Reason for revert: Un-reverting this seems to have caused these test failures: https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/3755 Original issue's description: > Revert of Revert of [MacViews] Implement AppWindowNativeWidgetMac::Maximize. (patchset #1 id:1 of https://codereview.chromium.org/1192373006/) > > Reason for revert: > The failing test cleared up without this revert, so relanding. > > Original issue's description: > > Revert of [MacViews] Implement AppWindowNativeWidgetMac::Maximize. (patchset #5 id:80001 of https://codereview.chromium.org/1184643003/) > > > > Reason for revert: > > This seems the most likely cause of a reliable Mac browser test failure. > > > > e.g https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/29726 > > > > Original issue's description: > > > [MacViews] Implement AppWindowNativeWidgetMac::Maximize. > > > > > > This makes MacViews behavior consistent with the existing Cocoa > > > implementation and adds a heap of tests for interactions between > > > Minimize, Restore, Maximize, and Fullscreen. > > > > > > This also changes NativeAppWindowCocoa behavior to be more > > > consistent with other platforms: > > > - isMaximized, isMinimized, isFullscreen are mutually exclusive, > > > - maximize() shows the window if it is minimized, > > > - restore() always restores the window size (in addition to unminimizing > > > and exiting fullscreen). > > > > > > This also fixes a bug in the Cocoa implementation where Maximize > > > changes the window frame while in fullscreen. > > > > > > BUG=459877 > > > > > > Committed: https://crrev.com/5c69ddcaa25a8d5a6963a7cab4bb6b6e5e636b78 > > > Cr-Commit-Position: refs/heads/master@{#335465} > > > > TBR=tapted@chromium.org,jackhou@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=459877 > > > > Committed: https://crrev.com/21d068fd8a2094ea45cb067a22c8f8bd87c4b1be > > Cr-Commit-Position: refs/heads/master@{#335493} > > TBR=tapted@chromium.org,jackhou@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=459877 > > Committed: https://crrev.com/2cf765dddad3b6f67e13c2ac1a4db4cfdd847f2c > Cr-Commit-Position: refs/heads/master@{#335513} TBR=tapted@chromium.org,jackhou@chromium.org,schenney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459877 Review URL: https://codereview.chromium.org/1196533003 Cr-Commit-Position: refs/heads/master@{#335531} --- extensions/components/native_app_window/native_app_window_views.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'extensions/components') diff --git a/extensions/components/native_app_window/native_app_window_views.cc b/extensions/components/native_app_window/native_app_window_views.cc index 0233623..e80e852 100644 --- a/extensions/components/native_app_window/native_app_window_views.cc +++ b/extensions/components/native_app_window/native_app_window_views.cc @@ -44,10 +44,10 @@ void NativeAppWindowViews::Init(AppWindow* app_window, Observe(app_window_->web_contents()); widget_ = new views::Widget; - widget_->AddObserver(this); InitializeWindow(app_window, create_params); OnViewWasResized(); + widget_->AddObserver(this); } NativeAppWindowViews::~NativeAppWindowViews() { -- cgit v1.1