From 2d124c0ce773bd5dd334e2c6168cbb66a4b224d6 Mon Sep 17 00:00:00 2001 From: avi Date: Tue, 22 Dec 2015 22:36:42 -0800 Subject: Switch to standard integer types in extensions/. BUG=138542 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/1543053002 Cr-Commit-Position: refs/heads/master@{#366716} --- extensions/renderer/messaging_bindings.cc | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'extensions/renderer/messaging_bindings.cc') diff --git a/extensions/renderer/messaging_bindings.cc b/extensions/renderer/messaging_bindings.cc index 777f24f..a0a855f 100644 --- a/extensions/renderer/messaging_bindings.cc +++ b/extensions/renderer/messaging_bindings.cc @@ -4,14 +4,16 @@ #include "extensions/renderer/messaging_bindings.h" +#include + #include #include -#include "base/basictypes.h" #include "base/bind.h" #include "base/bind_helpers.h" #include "base/callback.h" #include "base/lazy_instance.h" +#include "base/macros.h" #include "base/memory/weak_ptr.h" #include "base/message_loop/message_loop.h" #include "base/values.h" @@ -177,7 +179,7 @@ class ExtensionImpl : public ObjectBackedNativeHandler { if (!renderframe) return; - // Arguments are (int32 port_id, string message). + // Arguments are (int32_t port_id, string message). CHECK(args.Length() == 2 && args[0]->IsInt32() && args[1]->IsString()); int port_id = args[0].As()->Value(); @@ -196,7 +198,7 @@ class ExtensionImpl : public ObjectBackedNativeHandler { // Forcefully disconnects a port. void CloseChannel(const v8::FunctionCallbackInfo& args) { - // Arguments are (int32 port_id, boolean notify_browser). + // Arguments are (int32_t port_id, boolean notify_browser). CHECK_EQ(2, args.Length()); CHECK(args[0]->IsInt32()); CHECK(args[1]->IsBoolean()); @@ -218,7 +220,7 @@ class ExtensionImpl : public ObjectBackedNativeHandler { // A new port has been created for a context. This occurs both when script // opens a connection, and when a connection is opened to this script. void PortAddRef(const v8::FunctionCallbackInfo& args) { - // Arguments are (int32 port_id). + // Arguments are (int32_t port_id). CHECK_EQ(1, args.Length()); CHECK(args[0]->IsInt32()); @@ -230,7 +232,7 @@ class ExtensionImpl : public ObjectBackedNativeHandler { // frames with a reference to a given port, we will disconnect it and notify // the other end of the channel. void PortRelease(const v8::FunctionCallbackInfo& args) { - // Arguments are (int32 port_id). + // Arguments are (int32_t port_id). CHECK(args.Length() == 1 && args[0]->IsInt32()); ReleasePort(args[0].As()->Value()); } -- cgit v1.1