From 21d67e679792a286c581f20ea8e4848b9c34061e Mon Sep 17 00:00:00 2001 From: limasdf Date: Sat, 19 Dec 2015 04:04:49 -0800 Subject: Use rvalue reference instead of extensions::DictionaryBuilder::pass() C++ 11 enables rvalue reference with std::move() so that removing DictionaryBuilder::Pass(). BUG=563649 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1532193003 Cr-Commit-Position: refs/heads/master@{#366280} --- .../browser/api/identity/identity_api_unittest.cc | 19 +++++++++---------- .../browser/shell_native_app_window_aura_unittest.cc | 8 ++++---- 2 files changed, 13 insertions(+), 14 deletions(-) (limited to 'extensions/shell/browser') diff --git a/extensions/shell/browser/api/identity/identity_api_unittest.cc b/extensions/shell/browser/api/identity/identity_api_unittest.cc index 1802fdb..bf9248c 100644 --- a/extensions/shell/browser/api/identity/identity_api_unittest.cc +++ b/extensions/shell/browser/api/identity/identity_api_unittest.cc @@ -65,19 +65,18 @@ class IdentityApiTest : public ApiUnitTest { // Create an extension with OAuth2 scopes. set_extension( ExtensionBuilder() - .SetManifest( + .SetManifest(std::move( DictionaryBuilder() .Set("name", "Test") .Set("version", "1.0") - .Set( - "oauth2", - DictionaryBuilder() - .Set("client_id", - "123456.apps.googleusercontent.com") - .Set( - "scopes", - std::move(ListBuilder().Append( - "https://www.googleapis.com/auth/drive"))))) + .Set("oauth2", + std::move(DictionaryBuilder() + .Set("client_id", + "123456.apps.googleusercontent.com") + .Set("scopes", + std::move(ListBuilder().Append( + "https://www.googleapis.com/" + "auth/drive"))))))) .SetLocation(Manifest::UNPACKED) .Build()); } diff --git a/extensions/shell/browser/shell_native_app_window_aura_unittest.cc b/extensions/shell/browser/shell_native_app_window_aura_unittest.cc index 5592f1d..728e787 100644 --- a/extensions/shell/browser/shell_native_app_window_aura_unittest.cc +++ b/extensions/shell/browser/shell_native_app_window_aura_unittest.cc @@ -44,10 +44,10 @@ TEST_F(ShellNativeAppWindowAuraTest, Bounds) { new content::TestBrowserContext); scoped_refptr extension = ExtensionBuilder() - .SetManifest(DictionaryBuilder() - .Set("name", "test extension") - .Set("version", "1") - .Set("manifest_version", 2)) + .SetManifest(std::move(DictionaryBuilder() + .Set("name", "test extension") + .Set("version", "1") + .Set("manifest_version", 2))) .Build(); AppWindow* app_window = new AppWindow( -- cgit v1.1