From 007b3f812fc9c989fb99d4a668d8bd9c7807ad81 Mon Sep 17 00:00:00 2001 From: "dcheng@chromium.org" Date: Tue, 9 Apr 2013 08:46:45 +0000 Subject: Rewrite std::string("") to std::string(), Linux edition. This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98 --- google_apis/gaia/oauth2_mint_token_flow.cc | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) (limited to 'google_apis/gaia/oauth2_mint_token_flow.cc') diff --git a/google_apis/gaia/oauth2_mint_token_flow.cc b/google_apis/gaia/oauth2_mint_token_flow.cc index 42fc4ef..169d187 100644 --- a/google_apis/gaia/oauth2_mint_token_flow.cc +++ b/google_apis/gaia/oauth2_mint_token_flow.cc @@ -89,17 +89,16 @@ OAuth2MintTokenFlow::Parameters::Parameters( OAuth2MintTokenFlow::Parameters::~Parameters() {} -OAuth2MintTokenFlow::OAuth2MintTokenFlow( - URLRequestContextGetter* context, - Delegate* delegate, - const Parameters& parameters) - : OAuth2ApiCallFlow( - context, parameters.login_refresh_token, - "", std::vector()), +OAuth2MintTokenFlow::OAuth2MintTokenFlow(URLRequestContextGetter* context, + Delegate* delegate, + const Parameters& parameters) + : OAuth2ApiCallFlow(context, + parameters.login_refresh_token, + std::string(), + std::vector()), delegate_(delegate), parameters_(parameters), - ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) { -} + ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {} OAuth2MintTokenFlow::~OAuth2MintTokenFlow() { } -- cgit v1.1