From b52c239424acc212a50cc948159f33366dec43e4 Mon Sep 17 00:00:00 2001 From: "zea@chromium.org" Date: Fri, 11 Jul 2014 05:03:20 +0000 Subject: [GCM] Close the socket on connection factory shutdown We don't want to attempt to reuse a socket across shutdowns, and given socket pools any open socket can be reused. Make sure to close the socket on shutdown BUG=392546 Review URL: https://codereview.chromium.org/381273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282551 0039d316-1c4b-4281-b951-d872f2087c98 --- google_apis/gcm/engine/connection_factory_impl.cc | 1 + 1 file changed, 1 insertion(+) (limited to 'google_apis') diff --git a/google_apis/gcm/engine/connection_factory_impl.cc b/google_apis/gcm/engine/connection_factory_impl.cc index b1a43da..0ff3175 100644 --- a/google_apis/gcm/engine/connection_factory_impl.cc +++ b/google_apis/gcm/engine/connection_factory_impl.cc @@ -67,6 +67,7 @@ ConnectionFactoryImpl::ConnectionFactoryImpl( } ConnectionFactoryImpl::~ConnectionFactoryImpl() { + CloseSocket(); net::NetworkChangeNotifier::RemoveNetworkChangeObserver(this); if (pac_request_) { network_session_->proxy_service()->CancelPacRequest(pac_request_); -- cgit v1.1