From 467cbf47df58dbc215b058958bd07ab3d359c83e Mon Sep 17 00:00:00 2001 From: "dmurph@chromium.org" Date: Tue, 31 Jul 2012 01:19:13 +0000 Subject: Added null check for shader source when compiling, and fixed re-caching behavior to spec BUG=139711,139681 Review URL: https://chromiumcodereview.appspot.com/10826073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149104 0039d316-1c4b-4281-b951-d872f2087c98 --- .../service/memory_program_cache_unittest.cc | 34 +++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) (limited to 'gpu/command_buffer/service/memory_program_cache_unittest.cc') diff --git a/gpu/command_buffer/service/memory_program_cache_unittest.cc b/gpu/command_buffer/service/memory_program_cache_unittest.cc index 5d40785..7d3f3e6 100644 --- a/gpu/command_buffer/service/memory_program_cache_unittest.cc +++ b/gpu/command_buffer/service/memory_program_cache_unittest.cc @@ -38,7 +38,9 @@ class ProgramBinaryEmulator { GLsizei* length, GLenum* format, GLvoid* binary) { - *length = length_; + if (length) { + *length = length_; + } *format = format_; memcpy(binary, binary_, length_); } @@ -413,5 +415,35 @@ TEST_F(MemoryProgramCacheTest, LoadCorrectProgram) { NULL)); } +TEST_F(MemoryProgramCacheTest, OverwriteOnNewSave) { + const GLenum kFormat = 1; + const int kProgramId = 10; + const int kBinaryLength = 20; + char test_binary[kBinaryLength]; + for (int i = 0; i < kBinaryLength; ++i) { + test_binary[i] = i; + } + ProgramBinaryEmulator emulator(kBinaryLength, kFormat, test_binary); + + SetExpectationsForSaveLinkedProgram(kProgramId, &emulator); + cache_->SaveLinkedProgram(kProgramId, vertex_shader_, fragment_shader_, NULL); + + + char test_binary2[kBinaryLength]; + for (int i = 0; i < kBinaryLength; ++i) { + test_binary2[i] = (i*2) % 250; + } + ProgramBinaryEmulator emulator2(kBinaryLength, kFormat, test_binary2); + SetExpectationsForSaveLinkedProgram(kProgramId, &emulator2); + cache_->SaveLinkedProgram(kProgramId, vertex_shader_, fragment_shader_, NULL); + + SetExpectationsForLoadLinkedProgram(kProgramId, &emulator2); + EXPECT_EQ(ProgramCache::PROGRAM_LOAD_SUCCESS, cache_->LoadLinkedProgram( + kProgramId, + vertex_shader_, + fragment_shader_, + NULL)); +} + } // namespace gles2 } // namespace gpu -- cgit v1.1