From dec76e804867ced17b032571f440adf4945c4d99 Mon Sep 17 00:00:00 2001
From: "erg@google.com" <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu, 23 Sep 2010 22:43:53 +0000
Subject: FBTF: Move virtual methods to implementation files.

Remove logging.h and other headers where possible.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3461019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60369 0039d316-1c4b-4281-b951-d872f2087c98
---
 ipc/ipc_channel_proxy.h | 24 +++++++++---------------
 1 file changed, 9 insertions(+), 15 deletions(-)

(limited to 'ipc/ipc_channel_proxy.h')

diff --git a/ipc/ipc_channel_proxy.h b/ipc/ipc_channel_proxy.h
index bfebcb8..19aea28 100644
--- a/ipc/ipc_channel_proxy.h
+++ b/ipc/ipc_channel_proxy.h
@@ -55,42 +55,38 @@ class ChannelProxy : public Message::Sender {
   class MessageFilter
       : public base::RefCountedThreadSafe<MessageFilter, MessageFilterTraits> {
    public:
-    virtual ~MessageFilter() {}
+    virtual ~MessageFilter();
 
     // Called on the background thread to provide the filter with access to the
     // channel.  Called when the IPC channel is initialized or when AddFilter
     // is called if the channel is already initialized.
-    virtual void OnFilterAdded(Channel* channel) {}
+    virtual void OnFilterAdded(Channel* channel);
 
     // Called on the background thread when the filter has been removed from
     // the ChannelProxy and when the Channel is closing.  After a filter is
     // removed, it will not be called again.
-    virtual void OnFilterRemoved() {}
+    virtual void OnFilterRemoved();
 
     // Called to inform the filter that the IPC channel is connected and we
     // have received the internal Hello message from the peer.
-    virtual void OnChannelConnected(int32 peer_pid) {}
+    virtual void OnChannelConnected(int32 peer_pid);
 
     // Called when there is an error on the channel, typically that the channel
     // has been closed.
-    virtual void OnChannelError() {}
+    virtual void OnChannelError();
 
     // Called to inform the filter that the IPC channel will be destroyed.
     // OnFilterRemoved is called immediately after this.
-    virtual void OnChannelClosing() {}
+    virtual void OnChannelClosing();
 
     // Return true to indicate that the message was handled, or false to let
     // the message be handled in the default way.
-    virtual bool OnMessageReceived(const Message& message) {
-      return false;
-    }
+    virtual bool OnMessageReceived(const Message& message);
 
     // Called when the message filter is about to be deleted.  This gives
     // derived classes the option of controlling which thread they're deleted
     // on etc.
-    virtual void OnDestruct() {
-      delete this;
-    }
+    virtual void OnDestruct();
   };
 
   struct MessageFilterTraits {
@@ -111,9 +107,7 @@ class ChannelProxy : public Message::Sender {
                Channel::Listener* listener, MessageFilter* filter,
                MessageLoop* ipc_thread_loop);
 
-  virtual ~ChannelProxy() {
-    Close();
-  }
+  virtual ~ChannelProxy();
 
   // Close the IPC::Channel.  This operation completes asynchronously, once the
   // background thread processes the command to close the channel.  It is ok to
-- 
cgit v1.1