From 33c66e3473573743888019bd0e97eee01f548f81 Mon Sep 17 00:00:00 2001 From: "bauerb@chromium.org" Date: Mon, 20 Aug 2012 22:10:08 +0000 Subject: Enable verbose logging during PluginMsg_CreateInstance. This should get rid of the spurious ERROR messages when closing tabs, and log backtraces when we need them. BUG=141055 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151975 Review URL: https://chromiumcodereview.appspot.com/10834355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152395 0039d316-1c4b-4281-b951-d872f2087c98 --- ipc/ipc_sync_channel.cc | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'ipc') diff --git a/ipc/ipc_sync_channel.cc b/ipc/ipc_sync_channel.cc index 682286f..47d51b4 100644 --- a/ipc/ipc_sync_channel.cc +++ b/ipc/ipc_sync_channel.cc @@ -307,9 +307,9 @@ bool SyncChannel::SyncContext::TryToUnblockListener(const Message* msg) { bool send_result = deserializers_.back().deserializer-> SerializeOutputParameters(*msg); deserializers_.back().send_result = send_result; - LOG_IF(ERROR, !send_result) << "Couldn't deserialize reply message"; + VLOG_IF(1, !send_result) << "Couldn't deserialize reply message"; } else { - LOG(ERROR) << "Received error reply"; + VLOG(1) << "Received error reply"; } deserializers_.back().done_event->Signal(); @@ -363,7 +363,7 @@ void SyncChannel::SyncContext::OnChannelClosed() { void SyncChannel::SyncContext::OnSendTimeout(int message_id) { base::AutoLock auto_lock(deserializers_lock_); PendingSyncMessageQueue::iterator iter; - LOG(ERROR) << "Send timeout"; + VLOG(1) << "Send timeout"; for (iter = deserializers_.begin(); iter != deserializers_.end(); iter++) { if (iter->id == message_id) { iter->done_event->Signal(); @@ -375,7 +375,8 @@ void SyncChannel::SyncContext::OnSendTimeout(int message_id) { void SyncChannel::SyncContext::CancelPendingSends() { base::AutoLock auto_lock(deserializers_lock_); PendingSyncMessageQueue::iterator iter; - LOG(ERROR) << "Canceling pending sends"; + // TODO(bauerb): Remove once http://crbug/141055 is fixed. + VLOG(1) << "Canceling pending sends"; for (iter = deserializers_.begin(); iter != deserializers_.end(); iter++) iter->done_event->Signal(); } @@ -435,7 +436,7 @@ bool SyncChannel::SendWithTimeout(Message* message, int timeout_ms) { // *this* might get deleted in WaitForReply. scoped_refptr context(sync_context()); if (context->shutdown_event()->IsSignaled()) { - LOG(ERROR) << "shutdown event is signaled"; + VLOG(1) << "shutdown event is signaled"; delete message; return false; } -- cgit v1.1