From 413889301cc865ec50f36eb9f278669996b5679c Mon Sep 17 00:00:00 2001 From: "evan@chromium.org" Date: Tue, 16 Aug 2011 22:12:39 +0000 Subject: ipc: rename a variable to make code clearer It took me a while to understand this function because filters_ and filters represented two very different things. Review URL: http://codereview.chromium.org/7670006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97037 0039d316-1c4b-4281-b951-d872f2087c98 --- ipc/ipc_channel_proxy.cc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'ipc') diff --git a/ipc/ipc_channel_proxy.cc b/ipc/ipc_channel_proxy.cc index da3da24..dc990c2 100644 --- a/ipc/ipc_channel_proxy.cc +++ b/ipc/ipc_channel_proxy.cc @@ -194,22 +194,22 @@ void ChannelProxy::Context::OnSendMessage(Message* message) { // Called on the IPC::Channel thread void ChannelProxy::Context::OnAddFilter() { - std::vector > filters; + std::vector > new_filters; { base::AutoLock auto_lock(pending_filters_lock_); - filters.swap(pending_filters_); + new_filters.swap(pending_filters_); } - for (size_t i = 0; i < filters.size(); ++i) { - filters_.push_back(filters[i]); + for (size_t i = 0; i < new_filters.size(); ++i) { + filters_.push_back(new_filters[i]); // If the channel has already been created, then we need to send this // message so that the filter gets access to the Channel. if (channel_.get()) - filters[i]->OnFilterAdded(channel_.get()); - // Ditto for the peer process id. + new_filters[i]->OnFilterAdded(channel_.get()); + // Ditto for if the channel has been connected. if (peer_pid_) - filters[i]->OnChannelConnected(peer_pid_); + new_filters[i]->OnChannelConnected(peer_pid_); } } -- cgit v1.1