From 772a5b29a64d3490ea0cae5ee28b02d503b74a8d Mon Sep 17 00:00:00 2001 From: "hans@chromium.org" Date: Thu, 9 Aug 2012 20:39:12 +0000 Subject: Clean-up inline members of nested classes (ipc/) Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Review URL: https://chromiumcodereview.appspot.com/10825275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150891 0039d316-1c4b-4281-b951-d872f2087c98 --- ipc/ipc_channel_proxy.cc | 4 ++++ ipc/ipc_channel_proxy.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) (limited to 'ipc') diff --git a/ipc/ipc_channel_proxy.cc b/ipc/ipc_channel_proxy.cc index 0668b15..0b2338c 100644 --- a/ipc/ipc_channel_proxy.cc +++ b/ipc/ipc_channel_proxy.cc @@ -173,6 +173,10 @@ void ChannelProxy::Context::OnChannelClosed() { Release(); } +void ChannelProxy::Context::Clear() { + listener_ = NULL; +} + // Called on the IPC::Channel thread void ChannelProxy::Context::OnSendMessage(scoped_ptr message) { if (!channel_.get()) { diff --git a/ipc/ipc_channel_proxy.h b/ipc/ipc_channel_proxy.h index cce35f7..9755e13 100644 --- a/ipc/ipc_channel_proxy.h +++ b/ipc/ipc_channel_proxy.h @@ -226,7 +226,7 @@ class IPC_EXPORT ChannelProxy : public Sender { // Called on the consumers thread when the ChannelProxy is closed. At that // point the consumer is telling us that they don't want to receive any // more messages, so we honor that wish by forgetting them! - virtual void Clear() { listener_ = NULL; } + virtual void Clear(); private: friend class ChannelProxy; -- cgit v1.1