From dbc761a8dbaa7e81818b522db0de3797848ff128 Mon Sep 17 00:00:00 2001 From: "orenb@chromium.org" Date: Thu, 26 Jul 2012 01:29:21 +0000 Subject: Fixed several CHECKED_RETURN defects in ipc message utils cc CID_COUNT=3 CID=104154,104155,104156 BUG= TEST= TBR=jeremy Review URL: https://chromiumcodereview.appspot.com/10829024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148469 0039d316-1c4b-4281-b951-d872f2087c98 --- ipc/ipc_message_utils.cc | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'ipc') diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc index 66a6877..29159d0 100644 --- a/ipc/ipc_message_utils.cc +++ b/ipc/ipc_message_utils.cc @@ -51,6 +51,7 @@ bool ReadValue(const Message* m, PickleIterator* iter, Value** value, int recursion); void WriteValue(Message* m, const Value* value, int recursion) { + bool result; if (recursion > kMaxRecursionDepth) { LOG(WARNING) << "Max recursion depth hit in WriteValue."; return; @@ -63,25 +64,29 @@ void WriteValue(Message* m, const Value* value, int recursion) { break; case Value::TYPE_BOOLEAN: { bool val; - value->GetAsBoolean(&val); + result = value->GetAsBoolean(&val); + DCHECK(result); WriteParam(m, val); break; } case Value::TYPE_INTEGER: { int val; - value->GetAsInteger(&val); + result = value->GetAsInteger(&val); + DCHECK(result); WriteParam(m, val); break; } case Value::TYPE_DOUBLE: { double val; - value->GetAsDouble(&val); + result = value->GetAsDouble(&val); + DCHECK(result); WriteParam(m, val); break; } case Value::TYPE_STRING: { std::string val; - value->GetAsString(&val); + result = value->GetAsString(&val); + DCHECK(result); WriteParam(m, val); break; } -- cgit v1.1