From 007b3f812fc9c989fb99d4a668d8bd9c7807ad81 Mon Sep 17 00:00:00 2001 From: "dcheng@chromium.org" Date: Tue, 9 Apr 2013 08:46:45 +0000 Subject: Rewrite std::string("") to std::string(), Linux edition. This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98 --- jingle/glue/channel_socket_adapter_unittest.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'jingle/glue') diff --git a/jingle/glue/channel_socket_adapter_unittest.cc b/jingle/glue/channel_socket_adapter_unittest.cc index c9b0bb7..d90cbca 100644 --- a/jingle/glue/channel_socket_adapter_unittest.cc +++ b/jingle/glue/channel_socket_adapter_unittest.cc @@ -29,8 +29,7 @@ const int kTestError = -32123; class MockTransportChannel : public cricket::TransportChannel { public: - MockTransportChannel() - : cricket::TransportChannel("", 0) { + MockTransportChannel() : cricket::TransportChannel(std::string(), 0) { set_writable(true); set_readable(true); } -- cgit v1.1