From 58d1666040e4750a0d5662d35b44ab22c891c57c Mon Sep 17 00:00:00 2001 From: "lipalani@chromium.org" Date: Wed, 16 Feb 2011 01:44:45 +0000 Subject: Currently chrome sync subscribes to notifications on all datatypes regardless whether they are synced or not. This change list fixes that by subscribing to syncing datatypes only. Implementation: Whenever the data type are chosen by the user the syncapi is informed of the change by |data_type_manager_impl| class(in the UI thread). Syncapi then notifies the |server_notifier_thread| by means of a new API, on the sync core thread. |server_notifier_thread| then performs the work of notifying the tango servers on its worker thread. BUG=69477 TEST= Review URL: http://codereview.chromium.org/6362006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75048 0039d316-1c4b-4281-b951-d872f2087c98 --- jingle/notifier/listener/talk_mediator_impl.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'jingle/notifier') diff --git a/jingle/notifier/listener/talk_mediator_impl.h b/jingle/notifier/listener/talk_mediator_impl.h index 68b80cf..7af2721 100644 --- a/jingle/notifier/listener/talk_mediator_impl.h +++ b/jingle/notifier/listener/talk_mediator_impl.h @@ -24,7 +24,10 @@ namespace notifier { class TalkMediatorImpl : public TalkMediator, public MediatorThread::Observer { public: - // Takes ownership of |mediator_thread|. + // Takes ownership of |mediator_thread|. It is guaranteed that + // |mediator_thread| is destroyed only when this object is destroyed. + // This means that you can store a pointer to mediator_thread separately + // and use it until this object is destroyed. TalkMediatorImpl( MediatorThread* mediator_thread, bool invalidate_xmpp_auth_token, bool allow_insecure_connection); -- cgit v1.1