From db16bb04f3d1ab706af39d4094351ad7358f2725 Mon Sep 17 00:00:00 2001 From: rsleevi Date: Thu, 12 Nov 2015 15:47:17 -0800 Subject: Properly handle IPv6 literals in CONNECT requests When issuing a CONNECT, ensure that the Host header sent to the proxy sends the IPv6 literal in host-form (square brackets). Further, as the CONNECT details omit scheme data with respect to the proxy server's view of things, ensure that the port is included in the Host header as well (even for port 443). BUG=550011 Review URL: https://codereview.chromium.org/1413593011 Cr-Commit-Position: refs/heads/master@{#359438} --- jingle/glue/proxy_resolving_client_socket_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'jingle') diff --git a/jingle/glue/proxy_resolving_client_socket_unittest.cc b/jingle/glue/proxy_resolving_client_socket_unittest.cc index 7ec3716..1166f0d 100644 --- a/jingle/glue/proxy_resolving_client_socket_unittest.cc +++ b/jingle/glue/proxy_resolving_client_socket_unittest.cc @@ -85,7 +85,7 @@ TEST_F(ProxyResolvingClientSocketTest, ReportsBadProxies) { }; net::MockWrite writes[] = { net::MockWrite("CONNECT example.com:443 HTTP/1.1\r\n" - "Host: example.com\r\n" + "Host: example.com:443\r\n" "Proxy-Connection: keep-alive\r\n\r\n") }; net::StaticSocketDataProvider socket_data2(reads, arraysize(reads), -- cgit v1.1