From 20cb5f48d36abeb25bbf6cdd6a5f6debe014e8b1 Mon Sep 17 00:00:00 2001 From: "jamesr@chromium.org" Date: Wed, 16 Dec 2009 01:01:25 +0000 Subject: Give classes with virtual methods virtual protected destructors instead of implicit non-virtual public destructors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (Excluding chrome/browser/...) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) Patch by: Jacob Mandelson (jlmjln@gmail.com) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/200106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34633 0039d316-1c4b-4281-b951-d872f2087c98 --- media/base/clock.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'media/base/clock.h') diff --git a/media/base/clock.h b/media/base/clock.h index 93af4a9..f586b63 100644 --- a/media/base/clock.h +++ b/media/base/clock.h @@ -40,6 +40,9 @@ class Clock { // Returns the current elapsed media time. virtual base::TimeDelta Elapsed() const = 0; + + protected: + virtual ~Clock() {} }; } // namespace media -- cgit v1.1