From 284c5e97e4d17fa5c378b0f26117d1cea2fd65cc Mon Sep 17 00:00:00 2001 From: dmichael Date: Tue, 9 Dec 2014 12:02:47 -0800 Subject: Fix WeakPtrFactory ordering in media A lot of these followed the pattern of listing WeakPtr last, which isn't bad, but destructing WeakPtrFactory first invalidates *all* WeakPtrs it has vended. And doing this consistently will allow us to turn on a Clang checker (see the bug for more info). BUG=303818 R=xhwang@chromium.org Review URL: https://codereview.chromium.org/791633004 Cr-Commit-Position: refs/heads/master@{#307529} --- media/blink/buffered_data_source.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'media/blink/buffered_data_source.cc') diff --git a/media/blink/buffered_data_source.cc b/media/blink/buffered_data_source.cc index be8d0f2..e3e12e0 100644 --- a/media/blink/buffered_data_source.cc +++ b/media/blink/buffered_data_source.cc @@ -104,8 +104,8 @@ BufferedDataSource::BufferedDataSource( media_log_(media_log), host_(host), downloading_cb_(downloading_cb), - weak_factory_(this), - weak_ptr_(weak_factory_.GetWeakPtr()) { + weak_factory_(this) { + weak_ptr_ = weak_factory_.GetWeakPtr(); DCHECK(host_); DCHECK(!downloading_cb_.is_null()); DCHECK(render_task_runner_->BelongsToCurrentThread()); -- cgit v1.1