From 050b99242c2c385ff6b25658bc65b81b5576c12a Mon Sep 17 00:00:00 2001 From: "scherkus@chromium.org" Date: Fri, 22 Jul 2011 17:27:58 +0000 Subject: Remove VideoDecoder::ProvidesBuffer() and corresponding changes in VideoDecodeEngine. Every implementation returned true so no reason to complicate client code. Added OVERRIDE for relevant classes. BUG=none TEST=media_unittests, unit_tests Review URL: http://codereview.chromium.org/7482007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93666 0039d316-1c4b-4281-b951-d872f2087c98 --- media/video/video_decode_engine.h | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) (limited to 'media/video/video_decode_engine.h') diff --git a/media/video/video_decode_engine.h b/media/video/video_decode_engine.h index 2cefc44..fb6933d 100644 --- a/media/video/video_decode_engine.h +++ b/media/video/video_decode_engine.h @@ -19,8 +19,9 @@ class VideoDecodeContext; struct PipelineStatistics; -struct VideoStreamInfo { - VideoFrame::Format surface_format; +struct VideoCodecInfo { + // Other parameter is only meaningful when this is true. + bool success; // Can be different with container's value. uint32 surface_width; @@ -29,19 +30,6 @@ struct VideoStreamInfo { uint32 surface_height; }; -struct VideoCodecInfo { - // Other parameter is only meaningful when this is true. - bool success; - - // Whether decoder provides output buffer pool. - // TODO(hclam): This is not important anymore. Remove this. - bool provides_buffers; - - // Initial Stream Info. Only part of them could be valid. - // If they are not valid, Engine should update with OnFormatChange. - VideoStreamInfo stream_info; -}; - class VideoDecodeEngine { public: struct EventHandler { @@ -52,7 +40,6 @@ class VideoDecodeEngine { virtual void OnFlushComplete() = 0; virtual void OnSeekComplete() = 0; virtual void OnError() = 0; - virtual void OnFormatChange(VideoStreamInfo stream_info) = 0; // TODO(hclam): The following two methods shouldn't belong to this class // because they are not video decode events but used to send decoded -- cgit v1.1