From bf0d713a72db33bdf6c51d65f009f73e822db3e0 Mon Sep 17 00:00:00 2001 From: vmpstr Date: Thu, 24 Mar 2016 13:22:54 -0700 Subject: Add more out of line copy ctors for complex classes. This patch adds the remaining copy constructors for complex classes. After this patch, it should be possible to enable the heavy class copy constructor checks by default. R=thakis@chromium.org, dcheng@chromium.org TBR=jam@chromium.org BUG=436357 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1825273002 Cr-Commit-Position: refs/heads/master@{#383131} --- mojo/edk/system/request_context.cc | 3 +++ mojo/edk/system/request_context.h | 1 + mojo/shell/public/cpp/capabilities.h | 2 ++ mojo/shell/public/cpp/lib/capabilities.cc | 2 ++ 4 files changed, 8 insertions(+) (limited to 'mojo') diff --git a/mojo/edk/system/request_context.cc b/mojo/edk/system/request_context.cc index f4f70b5..e3666b2 100644 --- a/mojo/edk/system/request_context.cc +++ b/mojo/edk/system/request_context.cc @@ -90,6 +90,9 @@ RequestContext::WatchNotifyFinalizer::WatchNotifyFinalizer( : watcher(watcher), result(result), state(state) { } +RequestContext::WatchNotifyFinalizer::WatchNotifyFinalizer( + const WatchNotifyFinalizer& other) = default; + RequestContext::WatchNotifyFinalizer::~WatchNotifyFinalizer() {} } // namespace edk diff --git a/mojo/edk/system/request_context.h b/mojo/edk/system/request_context.h index 394e455..7aa0e69 100644 --- a/mojo/edk/system/request_context.h +++ b/mojo/edk/system/request_context.h @@ -67,6 +67,7 @@ class MOJO_SYSTEM_IMPL_EXPORT RequestContext { WatchNotifyFinalizer(scoped_refptr watcher, MojoResult result, const HandleSignalsState& state); + WatchNotifyFinalizer(const WatchNotifyFinalizer& other); ~WatchNotifyFinalizer(); scoped_refptr watcher; diff --git a/mojo/shell/public/cpp/capabilities.h b/mojo/shell/public/cpp/capabilities.h index 4ec4722..0b1b09a 100644 --- a/mojo/shell/public/cpp/capabilities.h +++ b/mojo/shell/public/cpp/capabilities.h @@ -23,6 +23,7 @@ using Name = std::string; struct CapabilityRequest { CapabilityRequest(); + CapabilityRequest(const CapabilityRequest& other); ~CapabilityRequest(); bool operator==(const CapabilityRequest& other) const; bool operator<(const CapabilityRequest& other) const; @@ -32,6 +33,7 @@ struct CapabilityRequest { struct CapabilitySpec { CapabilitySpec(); + CapabilitySpec(const CapabilitySpec& other); ~CapabilitySpec(); bool operator==(const CapabilitySpec& other) const; bool operator<(const CapabilitySpec& other) const; diff --git a/mojo/shell/public/cpp/lib/capabilities.cc b/mojo/shell/public/cpp/lib/capabilities.cc index add9150..a132fe6 100644 --- a/mojo/shell/public/cpp/lib/capabilities.cc +++ b/mojo/shell/public/cpp/lib/capabilities.cc @@ -7,6 +7,7 @@ namespace mojo { CapabilityRequest::CapabilityRequest() {} +CapabilityRequest::CapabilityRequest(const CapabilityRequest& other) = default; CapabilityRequest::~CapabilityRequest() {} bool CapabilityRequest::operator==(const CapabilityRequest& other) const { @@ -19,6 +20,7 @@ bool CapabilityRequest::operator<(const CapabilityRequest& other) const { } CapabilitySpec::CapabilitySpec() {} +CapabilitySpec::CapabilitySpec(const CapabilitySpec& other) = default; CapabilitySpec::~CapabilitySpec() {} bool CapabilitySpec::operator==(const CapabilitySpec& other) const { -- cgit v1.1