From 3fdc28cbc763c6702cc83a1ee716d527b09befbb Mon Sep 17 00:00:00 2001 From: bradnelson Date: Fri, 23 Jan 2015 12:03:25 -0800 Subject: Grab a bunch of owners / todos. Taking over some TODOs for noelallen and adding myself to OWNERS files in a few places. BUG=None TEST=None R=noelallen@chromium.org Review URL: https://codereview.chromium.org/875543002 Cr-Commit-Position: refs/heads/master@{#312909} --- native_client_sdk/src/build_tools/tests/parse_dsc_test.py | 2 +- native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc | 2 +- native_client_sdk/src/libraries/nacl_io/node.h | 2 +- native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc | 2 +- native_client_sdk/src/tests/nacl_io_test/event_test.cc | 4 ++-- native_client_sdk/src/tools/lib/get_shared_deps.py | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) (limited to 'native_client_sdk') diff --git a/native_client_sdk/src/build_tools/tests/parse_dsc_test.py b/native_client_sdk/src/build_tools/tests/parse_dsc_test.py index 05a8632..77f96b8 100755 --- a/native_client_sdk/src/build_tools/tests/parse_dsc_test.py +++ b/native_client_sdk/src/build_tools/tests/parse_dsc_test.py @@ -81,7 +81,7 @@ class TestValidateFormat(unittest.TestCase): testdesc['TOOLS'] = 'newlib' self._validate(testdesc, 'Key TOOLS expects LIST not STR.') -# TODO(noelallen): Add test which generates a real make and runs it. +# TODO(bradnelson): Add test which generates a real make and runs it. if __name__ == '__main__': unittest.main() diff --git a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc index d9d9567..c974f6b 100644 --- a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc +++ b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc @@ -972,7 +972,7 @@ int KernelProxy::utimens(const char* path, const struct timespec times[2]) { return FutimensInternal(node, times); } -// TODO(noelallen): Needs implementation. +// TODO(bradnelson): Needs implementation. int KernelProxy::link(const char* oldpath, const char* newpath) { LOG_TRACE("link is not implemented."); errno = EINVAL; diff --git a/native_client_sdk/src/libraries/nacl_io/node.h b/native_client_sdk/src/libraries/nacl_io/node.h index 54e6605..f1ebdc3c 100644 --- a/native_client_sdk/src/libraries/nacl_io/node.h +++ b/native_client_sdk/src/libraries/nacl_io/node.h @@ -140,7 +140,7 @@ class Node : public sdk_util::RefObject { sdk_util::SimpleLock node_lock_; // We use a pointer directly to avoid cycles in the ref count. - // TODO(noelallen) We should change this so it's unnecessary for the node + // TODO(bradnelson) We should change this so it's unnecessary for the node // to track it's parent. When a node is unlinked, the filesystem should do // any cleanup it needs. Filesystem* filesystem_; diff --git a/native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc b/native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc index 95cc4f3..4eaf6ac 100644 --- a/native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc +++ b/native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc @@ -364,7 +364,7 @@ Error SocketNode::RecvHelper(const HandleAttr& attr, if ((flags & MSG_DONTWAIT) || !attr.IsBlocking()) ms = 0; - // TODO(noelallen) BUG=295177 + // TODO(bradnelson) BUG=295177 // For UDP we should support filtering packets when using connect EventListenerLock wait(GetEventEmitter()); Error err = wait.WaitOnEvent(POLLIN, ms); diff --git a/native_client_sdk/src/tests/nacl_io_test/event_test.cc b/native_client_sdk/src/tests/nacl_io_test/event_test.cc index 8084df0..f85f9e2 100644 --- a/native_client_sdk/src/tests/nacl_io_test/event_test.cc +++ b/native_client_sdk/src/tests/nacl_io_test/event_test.cc @@ -290,7 +290,7 @@ TEST_F(SelectPollTest, PollMemPipe) { SetFDs(fds, 2); ASSERT_EQ(2, kp->poll(pollfds, 2, 0)); - // TODO(noelallen) fix poll based on open mode + // TODO(bradnelson) fix poll based on open mode // EXPECT_EQ(0, pollfds[0].revents); // Bug 291018 ASSERT_EQ(POLLOUT, pollfds[1].revents); @@ -325,7 +325,7 @@ TEST_F(SelectPollTest, SelectMemPipe) { ASSERT_EQ(2, kp->select(fds[1] + 1, &rd_set, &wr_set, &ex_set, &tv)); EXPECT_EQ(0, FD_ISSET(fds[0], &rd_set)); EXPECT_EQ(0, FD_ISSET(fds[1], &rd_set)); - // TODO(noelallen) fix poll based on open mode + // TODO(bradnelson) fix poll based on open mode // EXPECT_EQ(0, FD_ISSET(fds[0], &wr_set)); // Bug 291018 EXPECT_NE(0, FD_ISSET(fds[1], &wr_set)); diff --git a/native_client_sdk/src/tools/lib/get_shared_deps.py b/native_client_sdk/src/tools/lib/get_shared_deps.py index b7b433f..7a355ca 100644 --- a/native_client_sdk/src/tools/lib/get_shared_deps.py +++ b/native_client_sdk/src/tools/lib/get_shared_deps.py @@ -211,7 +211,7 @@ def _FindLibsInPath(name, lib_path): # the SONAME is actually libc.so. If we pass glibc's libc.so to objdump # if fails to parse it, os this filters out libc.so expept for within # the bionic toolchain. - # TODO(noelallen): Remove this once the SONAME in bionic is made to be + # TODO(bradnelson): Remove this once the SONAME in bionic is made to be # unique in the same it is under glibc: # https://code.google.com/p/nativeclient/issues/detail?id=3833 rel_dirname = os.path.relpath(dirname, SDK_DIR) -- cgit v1.1