From 3e377c5a80be45d36a6015c80d9e2dae525cf042 Mon Sep 17 00:00:00 2001 From: "aa@chromium.org" Date: Thu, 6 Aug 2009 07:46:37 +0000 Subject: Revert of r22559. This caused an easily reproducible crash: 1. Start with a fresh profile 2. Navigate to google.com 3. Restart 4. Navigate to google.com 5. crash The change from pass-by-value to pass-by-ref in fav_icon_helper.* seems to be to blame, but I can't see it right off. TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98 --- net/base/file_stream_posix.cc | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'net/base/file_stream_posix.cc') diff --git a/net/base/file_stream_posix.cc b/net/base/file_stream_posix.cc index aac0be2..5c55781 100644 --- a/net/base/file_stream_posix.cc +++ b/net/base/file_stream_posix.cc @@ -290,15 +290,12 @@ void FileStream::AsyncContext::RunAsynchronousCallback() { // FileStream ------------------------------------------------------------ -FileStream::FileStream() - : file_(base::kInvalidPlatformFileValue), - open_flags_(0) { +FileStream::FileStream() : file_(base::kInvalidPlatformFileValue) { DCHECK(!IsOpen()); } FileStream::FileStream(base::PlatformFile file, int flags) - : file_(file), - open_flags_(flags) { + : file_(file), open_flags_(flags) { // If the file handle is opened with base::PLATFORM_FILE_ASYNC, we need to // make sure we will perform asynchronous File IO to it. if (flags & base::PLATFORM_FILE_ASYNC) { -- cgit v1.1