From 0b330bf9a3164dc61ce4b88c386e44c36e7bfa60 Mon Sep 17 00:00:00 2001 From: "eroman@chromium.org" Date: Tue, 11 May 2010 03:51:06 +0000 Subject: Remove the HOST_RESOLVER_IMPL_OBSERVER_* log events. I have never found these to be useful, and they just add noise to the log. Review URL: http://codereview.chromium.org/2033008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46885 0039d316-1c4b-4281-b951-d872f2087c98 --- net/base/host_resolver_impl.cc | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'net/base/host_resolver_impl.cc') diff --git a/net/base/host_resolver_impl.cc b/net/base/host_resolver_impl.cc index ffaada3..5d0a85e 100644 --- a/net/base/host_resolver_impl.cc +++ b/net/base/host_resolver_impl.cc @@ -878,14 +878,10 @@ void HostResolverImpl::OnStartRequest(const BoundNetLog& net_log, // Notify the observers of the start. if (!observers_.empty()) { - net_log.BeginEvent(NetLog::TYPE_HOST_RESOLVER_IMPL_OBSERVER_ONSTART, NULL); - for (ObserversList::iterator it = observers_.begin(); it != observers_.end(); ++it) { (*it)->OnStartResolution(request_id, info); } - - net_log.EndEvent(NetLog::TYPE_HOST_RESOLVER_IMPL_OBSERVER_ONSTART, NULL); } } @@ -895,15 +891,11 @@ void HostResolverImpl::OnFinishRequest(const BoundNetLog& net_log, int error) { // Notify the observers of the completion. if (!observers_.empty()) { - net_log.BeginEvent(NetLog::TYPE_HOST_RESOLVER_IMPL_OBSERVER_ONFINISH, NULL); - bool was_resolved = error == OK; for (ObserversList::iterator it = observers_.begin(); it != observers_.end(); ++it) { (*it)->OnFinishResolutionWithStatus(request_id, was_resolved, info); } - - net_log.EndEvent(NetLog::TYPE_HOST_RESOLVER_IMPL_OBSERVER_ONFINISH, NULL); } net_log.EndEvent(NetLog::TYPE_HOST_RESOLVER_IMPL, NULL); @@ -916,14 +908,10 @@ void HostResolverImpl::OnCancelRequest(const BoundNetLog& net_log, // Notify the observers of the cancellation. if (!observers_.empty()) { - net_log.BeginEvent(NetLog::TYPE_HOST_RESOLVER_IMPL_OBSERVER_ONCANCEL, NULL); - for (ObserversList::iterator it = observers_.begin(); it != observers_.end(); ++it) { (*it)->OnCancelResolution(request_id, info); } - - net_log.EndEvent(NetLog::TYPE_HOST_RESOLVER_IMPL_OBSERVER_ONCANCEL, NULL); } net_log.EndEvent(NetLog::TYPE_HOST_RESOLVER_IMPL, NULL); -- cgit v1.1