From 007b3f812fc9c989fb99d4a668d8bd9c7807ad81 Mon Sep 17 00:00:00 2001 From: "dcheng@chromium.org" Date: Tue, 9 Apr 2013 08:46:45 +0000 Subject: Rewrite std::string("") to std::string(), Linux edition. This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98 --- net/ftp/ftp_util.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'net/ftp') diff --git a/net/ftp/ftp_util.cc b/net/ftp/ftp_util.cc index 0eab465..68307a2 100644 --- a/net/ftp/ftp_util.cc +++ b/net/ftp/ftp_util.cc @@ -107,7 +107,7 @@ std::string FtpUtil::VMSPathToUnix(const std::string& vms_path) { std::string result(vms_path); if (vms_path[0] == '[') { // It's a relative path. - ReplaceFirstSubstringAfterOffset(&result, 0, "[.", ""); + ReplaceFirstSubstringAfterOffset(&result, 0, "[.", std::string()); } else { // It's an absolute path. result.insert(0, "/"); -- cgit v1.1