From 66761b95332549f825999e482c17c94675275f49 Mon Sep 17 00:00:00 2001 From: "pkasting@chromium.org" Date: Fri, 25 Jun 2010 21:30:38 +0000 Subject: Massively simplify the NetworkChangeNotifier infrastructure: * Use a process-wide object (singleton pattern) * Create/destroy this object on the main thread, make it outlive all consumers * Make observer-related functions threadsafe As a result, the notifier can now be used by any thread (eliminating things like NetworkChangeObserverProxy and NetworkChangeNotifierProxy, and expanding its usefulness); its creation and inner workings are much simplified (eliminating implementation-specific classes); and it is simpler to access (eliminating things like NetworkChangeNotifierThread and a LOT of passing pointers around). BUG=none TEST=Unittests; network changes still trigger notifications Review URL: http://codereview.chromium.org/2802015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50895 0039d316-1c4b-4281-b951-d872f2087c98 --- net/http/http_network_layer_unittest.cc | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) (limited to 'net/http/http_network_layer_unittest.cc') diff --git a/net/http/http_network_layer_unittest.cc b/net/http/http_network_layer_unittest.cc index 9f20943..274d2dc 100644 --- a/net/http/http_network_layer_unittest.cc +++ b/net/http/http_network_layer_unittest.cc @@ -16,9 +16,9 @@ class HttpNetworkLayerTest : public PlatformTest { }; TEST_F(HttpNetworkLayerTest, CreateAndDestroy) { - net::HttpNetworkLayer factory( - NULL, NULL, new net::MockHostResolver, net::ProxyService::CreateNull(), - new net::SSLConfigServiceDefaults, NULL, NULL, NULL); + net::HttpNetworkLayer factory(NULL, new net::MockHostResolver, + net::ProxyService::CreateNull(), new net::SSLConfigServiceDefaults, NULL, + NULL, NULL); scoped_ptr trans; int rv = factory.CreateTransaction(&trans); @@ -27,9 +27,9 @@ TEST_F(HttpNetworkLayerTest, CreateAndDestroy) { } TEST_F(HttpNetworkLayerTest, Suspend) { - net::HttpNetworkLayer factory( - NULL, NULL, new net::MockHostResolver, net::ProxyService::CreateNull(), - new net::SSLConfigServiceDefaults, NULL, NULL, NULL); + net::HttpNetworkLayer factory(NULL, new net::MockHostResolver, + net::ProxyService::CreateNull(), new net::SSLConfigServiceDefaults, NULL, + NULL, NULL); scoped_ptr trans; int rv = factory.CreateTransaction(&trans); @@ -67,11 +67,9 @@ TEST_F(HttpNetworkLayerTest, GET) { data_writes, arraysize(data_reads)); mock_socket_factory.AddSocketDataProvider(&data); - net::HttpNetworkLayer factory(&mock_socket_factory, NULL, - new net::MockHostResolver, - net::ProxyService::CreateNull(), - new net::SSLConfigServiceDefaults, - NULL, NULL, NULL); + net::HttpNetworkLayer factory(&mock_socket_factory, new net::MockHostResolver, + net::ProxyService::CreateNull(), new net::SSLConfigServiceDefaults, NULL, + NULL, NULL); TestCompletionCallback callback; -- cgit v1.1