From 45ceea944499f4f81f298a2e456d0ed720656310 Mon Sep 17 00:00:00 2001 From: "rsleevi@chromium.org" Date: Fri, 22 Apr 2011 02:37:48 +0000 Subject: Address post-review feedback for r82214. In addition, no longer attempt to gracefully recover from read errors when deserializing a X509Certificate from a Pickle. R=wtc BUG=7065 TEST=none Review URL: http://codereview.chromium.org/6880094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82618 0039d316-1c4b-4281-b951-d872f2087c98 --- net/http/http_response_info.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'net/http') diff --git a/net/http/http_response_info.cc b/net/http/http_response_info.cc index 49090e0..5aee4b1 100644 --- a/net/http/http_response_info.cc +++ b/net/http/http_response_info.cc @@ -31,6 +31,8 @@ enum { RESPONSE_INFO_VERSION_MASK = 0xFF, // This bit is set if the response info has a cert at the end. + // Version 1 serialized only the end-entity certificate, while subsequent + // versions include the available certificate chain. RESPONSE_INFO_HAS_CERT = 1 << 8, // This bit is set if the response info has a security-bits field (security @@ -135,8 +137,6 @@ bool HttpResponseInfo::InitFromPickle(const Pickle& pickle, // read ssl-info if (flags & RESPONSE_INFO_HAS_CERT) { - // Version 1 only serialized only the end-entity certificate, - // while subsequent versions include the entire chain. X509Certificate::PickleType type = (version == 1) ? X509Certificate::PICKLETYPE_SINGLE_CERTIFICATE : X509Certificate::PICKLETYPE_CERTIFICATE_CHAIN; -- cgit v1.1