From 7bffd08c27787a806bd89529e694ffa3f90883cb Mon Sep 17 00:00:00 2001 From: "eroman@chromium.org" Date: Thu, 22 Oct 2009 20:06:52 +0000 Subject: Change the request tracking done by about:net-internals to be per context rather than global accross all contexts. Before there was a singleton "request tracker" (URLRequest::InstanceTracker) that kept track of all outstanding requests and recently completed. Whereas now, each URLRequestContext gets its own "request tracker" (URLRequestTracker) to track the requests associated with that context. This change is to limit the lifetime of information relating to incognito windows. Before you were able to see the recent requests issued by incognito windows even after the last incognito windows was closed (by loading about:net-internals in a non-incognito window). Whereas now you can only see the incognito requests information by loading "about:net-internals" within an incognito tab. And once the last incognito tab is closed, the OTR context is destroyed, which in turn destroys any profiling information that was being stored. BUG=24630 Review URL: http://codereview.chromium.org/295050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29804 0039d316-1c4b-4281-b951-d872f2087c98 --- net/net.gyp | 3 +++ 1 file changed, 3 insertions(+) (limited to 'net/net.gyp') diff --git a/net/net.gyp b/net/net.gyp index f7dbe0e0..aa6e94a 100644 --- a/net/net.gyp +++ b/net/net.gyp @@ -449,6 +449,8 @@ 'url_request/url_request_status.h', 'url_request/url_request_test_job.cc', 'url_request/url_request_test_job.h', + 'url_request/url_request_tracker.cc', + 'url_request/url_request_tracker.h', 'url_request/url_request_view_net_internals_job.cc', 'url_request/url_request_view_net_internals_job.h', 'url_request/view_cache_helper.cc', @@ -617,6 +619,7 @@ 'socket/tcp_client_socket_pool_unittest.cc', 'socket/tcp_client_socket_unittest.cc', 'socket/tcp_pinger_unittest.cc', + 'url_request/url_request_tracker_unittest.cc', 'url_request/url_request_unittest.cc', 'url_request/url_request_unittest.h', 'websockets/websocket_unittest.cc', -- cgit v1.1