From b59ff376c5d5b950774fcbe65727611d51832b75 Mon Sep 17 00:00:00 2001 From: "ericroman@google.com" Date: Wed, 15 Jul 2009 22:04:32 +0000 Subject: Refactorings surrounding HostResolver: (1) Extract HostResolver to an interface. The existing concrete implementation is now named HostResolverImpl. This makes it possible to create mocks with more complex behavior (i.e. choose via rules if response will be sync vs async). (2) Transform HostMapper into HostResolverProc. Conceptually HostResolverProc maps a hostname to a socket address, whereas HostMapper mapped a hostname to another hostname (so you were still at the mercy of the system's host resolver). With HostResolverProc you can specify the exact AddressList, making it possible to run tests requiring IPv6 socketaddrs on systems (like WinXP) that don't actually support it. (3) Add a MockHostResolver implementation of HostResolver. This replaces the [ScopedHostMapper + RuleBasedHostMapper + HostResolver] combo. It is less clunky and a bit more expressive. BUG=http://crbug.com/16452 R=willchan TEST=existing Review URL: http://codereview.chromium.org/149511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20795 0039d316-1c4b-4281-b951-d872f2087c98 --- net/proxy/proxy_resolver_v8.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'net/proxy/proxy_resolver_v8.h') diff --git a/net/proxy/proxy_resolver_v8.h b/net/proxy/proxy_resolver_v8.h index 3bf2bec..6fbc968 100644 --- a/net/proxy/proxy_resolver_v8.h +++ b/net/proxy/proxy_resolver_v8.h @@ -56,7 +56,7 @@ class ProxyResolverV8 : public ProxyResolver { // Creates a default javascript bindings implementation that will: // - Send script error messages to LOG(INFO) // - Send script alert()s to LOG(INFO) - // - Use the provided host mapper to service dnsResolve(). + // - Use the provided host resolver to service dnsResolve(). // // For clients that need more control (for example, sending the script output // to a UI widget), use the ProxyResolverV8(JSBindings*) and specify your -- cgit v1.1